-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 64-bit binaries in elf/dl #289
Conversation
c.f., the list of LuaJIT LJ_ARCH_NAME values And LuaJIT/LuaJIT@3134359
But at least this only requires tweaking the cdecl, not the generated output...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you say so. :-P
The standalone example worked before, but I guess it was because LuaJIT was part of the main shared lib? |
@pazos: What standalone example? ^^. (The two formats are very similar, there's a vague chance using the Elf32 data types on a 64-bit host mostly worked for what we were doing). |
@NiLuJe examples/helloWorld I imagine |
Yep, confirmed that it failed on Elf64 files before (random test on an x64 binary ;p).
|
when runnign from the main repo directory
vaguely resembles an ELF binary
It's liable to be more informative, and tell us exactly *why* it failed to open.
Because the string from error might be lost in the logcat noise, or something, depending on who catches it.
Tweaked the logging and asserts some more, and actually tested on a real device ;p. |
* Bump base koreader/koreader-base#1293 koreader/koreader-base#1294 Fix #7187 * Bump android-luajit-launcher koreader/android-luajit-launcher#289 koreader/android-luajit-launcher#292 Fix #7193
That should hopefully have been the last non-toolchain-related hurdle for an aarch64 build ;).
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)