Android: Fix nightmode on devices w/ RGB565 windows w/ the C blitter #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xref: koreader/koreader#7187 |
|
In practice, this might end up being slower than the Lua BB, and the invert is not accurate, unlike in Lua. But at least it doesn't crash ;p. Yay, RGB565! |
Frenzie
changed the title
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jan 26, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Jan 26, 2021
* Bump base koreader/koreader-base#1293 koreader/koreader-base#1294 Fix #7187 * Bump android-luajit-launcher koreader/android-luajit-launcher#289 koreader/android-luajit-launcher#292 Fix #7193
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
…oreader#1293) The CBB can't do an invertBlitFrom if source & dest type don't match, so, do it another way in these instances ;).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of whether we actually could potentially coerce those buffers to RGB32, the sanity check makes sense ;).
This change is