Inter word text decoration, fix TOC page numbers, reproducible cache files #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the added space between words to ensure text justification, underline (eg: for links spanning multiple words) could have some cuts.
As page numbers are calculated only when needed, they could still gather old numbers after book re-rendering, which could lead to wrong TOC page numbers when loading from cache.
Have cache files have the same file checksum by zero'ing struct padding, getting rid of random data when they are serialized into the cache file.
|
(I'll bump that after next stable.) |
This was referenced May 9, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure text decoration (underline) is continued over word gaps
Depending on the added space between words to ensure text justification, underline (eg: for links spanning multiple words) could have some cuts.
(We can still have some cuts when the words are in distinct text nodes, eg with
<a href="">Louis <span class=roman>XIV</span></a>, less easy to fix.)Before:
After:
Invalidate TOC page numbers on rendering change
As page numbers are calculated only when needed, they could still gather old numbers after book re-rendering, which could lead to wrong TOC page numbers when loading from cache. Details along koreader/koreader#4972 (comment)
Ensure reproducible cache files when same rendering settings
Have cache files have the same file checksum by zero'ing struct padding, getting rid of random data when they are serialized into the cache file. Details along koreader/koreader#4972 (comment)