Upstream list item tweaks, allow 2-pages mode without constraints #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from d76b2f3: forgot to add +1 to the length when converting quotes to strings.
Support reversed list item counting. The start defaults to the number of list elements when counting is reversed. Fix the count to advance irrespective of the list style. Avoid walking the elements if the list element has a value defined.
Add option to prevent crengine from doing its W/H > 6/5 and W > 20em checks to allow 2-pages mode, so frontends can propose it too in portrait mode. Also remove the thin line separator that was only showing on color screen.
poire-z
force-pushed
the
misc_listitems_tweaks
branch
from
83e1e51
to
2cba441
Compare
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(chore) Silence some clang warnings(Upstream) CSS content: fix regression with open-quote/close-quotebuggins/coolreader#215. Regression from #379 d76b2f3
(Upstream) HTML lists: support the 'reversed' attributebuggins/coolreader#212 + fix from buggins/coolreader#227
(Upstream) Tweak list items disc/circle/square symbolsFrom buggins/coolreader#217
2-pages mode: option to skip geometry checksSo CoolReader can keep it, put we can bypass them in KOReader.
See koreader/koreader#7129 (comment)
Also removed the thin line separator that was only showing on color screen (no need for a thin line separator: the middle margin was sized to be like the other margins: a separator would cut it in half and make it look like two smaller margins).
This change is