-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to enable 'Dual Pages' also in portrait format? #7129
Comments
Not easily - it's not just a matter of removing this koreader/frontend/ui/data/creoptions.lua Lines 34 to 54 in 47568ae
crengine (our EPUB engine) will itself prevent going dual page in some conditions: koreader/frontend/apps/reader/modules/readerrolling.lua Lines 1019 to 1032 in 47568ae
Would need to remove bits in this check: Not really nice, but might be useful to people with bad progressive glasses with a very narrow reading view and a stuck neck :) So, not currently possible, but might be. Waiting for more feedback if we should. |
Yes, there are myopic readers who can easily read small fontsizes without glasses. Aside from that devices are getting bigger such as InkPad X . In my opinion this would give the reader a more fexible way to use his device. If it is not too much effort I would appreceate this option could be enabled also for portrait format. |
Yes, I am severely nearsighted. |
Ok, I can get that working. 2 questions:
(Although we have room on that left most bottom panel, so we could have 1 or 2 more toggles - but let's pretend I didn't wrote that :) |
I don't think switching from landscape to portrait is a big problem, because the content will have to get rendered anyway. So there are different line and page breaks. Maybe it would be a good idea not to close the bottom menu on rotation. Then the user can decide if he/she wants two pages/columns or one page/column on rotation.
I have no real preference about the gray separator line. |
Another idea: in portrait mode two pages are more two columns. Would it be possible to name the option something like "two columns" in portrait and "two pages" in landscape mode? |
Well, that's a bit more difficult than for all the other cases, as there's a change in geometry and everything is closed to be later recreated with the new size. So, not taking this painful idea :)
May be from how it would look - but they are still 2 pages: a tap will increment the page count in the footer by 2, the Skim To +1/-1 buttons will do nothing every other tap. Solving this (that I don't intend to) would make them 2 columns in all cases. |
I think that's confusing more than anything, even if it's more accurate in some ways. :-) |
I only read in dual page and also would love to try it in portrait mode. |
OK, #7138 should be in tomorrow's nightly. |
Thank you. I will play with it.
Am 13. Jänner 2021 19:13:14 MEZ schrieb poire-z <notifications@github.com>:
…OK, #7138 should be in tomorrow's nightly.
Please play with it tomorrow, and let me know if there's an obvious
usability issue before next release (possibly next weekend).
(I removed the thin line separator, so you'll stop having it on color
screens.)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#7129 (comment)
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
@poire-z: The only thing which is slightly annoying with two columns/pages in portrait mode is, that progress bar in the top status bar only uses the right half. |
That's... fun. Did it work in landscape? |
It's the same behavior in landscape and portrait.
Am 14. Jänner 2021 19:12:58 MEZ schrieb NiLuJe <notifications@github.com>:
…That's... fun. Did it work in landscape?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#7129 (comment)
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
Thanks for the feedback.
I guess it's because there's a cut in the line, to not have a long line kill the feeling of 2 pages. With the separator I removed: Having the progress bar span over the separator would look bad. The code involved is around https://github.com/koreader/crengine/blob/a90c0be089b08e0b0af64289fb0fdc8ba6d5ca6b/crengine/src/lvdocview.cpp#L1683-L1773 |
Fwiw (since I don't really use the feature), I've never cared for that separator in the middle. |
With the following patch would allow to show the full header is shown in dual page/columns (on portrait and landscape).
|
^ the progress bar is now wide, but I don't see the book title, just the author: Another idea if we don't want to disrupt how it shows currently is just to have the progress bar being 2 segments, so it would just skip the blank. Pinging CoolReader's @virxkane - as this is the main status bar in CoolReader, to be involved in the discussion if we're going to change it (only how it look in "2 pages modes / VisiblePages == 2") |
Sorry, but I have accumulated a lot of unfinished business, and this code is not familiar to me, so I cannot help right now. Later, I or someone else will have to deal with this :( |
It seems there is a limitation on the length, in the usual one-page mode, also, if it does not fit, then the author and the title are displayed alternately. I.e on one page - the author, on the next - the title. |
That's alright! :) |
@virxkane: Thanks, that was the problem. The following diff is not quite beautiful (empty statement), but does the trick to show what it will look like :)
|
I think it makes sense to also ask @hius07's opinion. |
^^ makes sense. Or may be cleaner: just not take the 2 pages paths when isPortraitMode. (An additional improvement to landscape mode would be to have the progress bar displays ticks and progress on the 2 segments.) |
I have created PR koreader/crengine#408. So we can discuss easier. |
Some discussion has continued in koreader/crengine#408 - but getting back on it here as it's more visible than there.
A few more questions / requests for opinion related to all this. A This issue would not exist in "2-column-as-1-page" mode, but it exists in the current "2-pages" mode: when showing 2 pages, which page number should the footer and header show: the page number of the left page or the one of the right page ? Because currently, header and footer disagree: B This also happens in one-page mode: when one (or two) pages shows more than one chapter, which chapter to use to display in the footer ? The first one, or the last one in view? C With "2-column-as-1-page", which is just masquerading page numbers while still having crengine working with them as 2-pages, how far should we push the "2-column-as-1-page" principle with page-breaks ? |
I would generally say the first one. Possible exception if it's just one or
two lines.
…On Wed, Jan 20, 2021, 14:23 poire-z ***@***.***> wrote:
Some discussion has continued in koreader/crengine#408
<koreader/crengine#408> - but getting back on it
here as it's more visible than there.
If all that happens to be working well, are we all fine to go with that
too in landscape mode, for consistency? With
twoVisiblePagesAsOnePageNumber=true, meaning: single wide header, current
page number and total page count being the number of screen views - so what
we see would need to be thought of as 2-columns on a single page, and no
longer 2-pages. (We then would need to rename "Dual Page" to "Two Columns").
I'd prefer this to be hardcoded and not a user toggle, it's a KOReader
choice to present things that way (CoolReader would get the current
behaviour, until they decide to set the new property and may be need some
frontend tweaks) - and it's the same in landscape and portrait, no reason
(except old habits if really hard to lose) to change the
meaning/page-number-steps in the footer whether in portrait vs landscape.
(If not, and we'd still want to keep dual-page and make it a first class
citizen, a few other tweaks would be needed, like in the SkimTo widget,
replacing +1 with +2 - so we don't get half the taps ineffective :)
A few more questions / requests for opinion related to all this.
*A* This issue would not exist in "2-column-as-1-page" mode, but it
exists in the current "2-pages" mode: when showing 2 pages, which page
number should the footer and header show: the page number of the left page
or the one of the right page ? Because currently, header and footer
disagree:
[image: image]
<https://user-images.githubusercontent.com/24273478/105178216-083d8100-5b28-11eb-9d12-2b08e9c78540.png>
On this, when showing the first and second page of a book, which unique
page number feels the right one to show?
*B* This also happens in one-page mode: when one (or two) pages shows
more than one chapter, which chapter to use to display in the footer ? The
first one, or the last one in view?
Currently in 2-pages mode:
[image: image]
<https://user-images.githubusercontent.com/24273478/105178626-9285e500-5b28-11eb-98e5-60ebb40329e0.png>
which would be in 2-column-as-1-page:
[image: image]
<https://user-images.githubusercontent.com/24273478/105178859-dd9ff800-5b28-11eb-854c-c7b7d8e6da6f.png>
I would personally expect all to show as current chapter: "4.5 Property".
Thoughts?
*C* With "2-column-as-1-page", which is just masquerading page numbers
while still having crengine working with them as 2-pages, how far should we
push the "2-column-as-1-page" principle with page-breaks ?
This publisher page break would be a column break:
[image: image]
<https://user-images.githubusercontent.com/24273478/105179562-c6153f00-5b29-11eb-853b-ad21e86f6516.png>
Should we add a blank "column" on the right so it really becomes a
page/view break?
Or is it just ok to consider page-breaks as column-breaks ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7129 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRQBIJNALTENRFKJXEJMLS23KL5ANCNFSM4V4NQHUA>
.
|
I'd like a publisher page break to be a page break, so to add a blank column. |
To question A: I would go for the number of the right page (as the pagenumber is on the right half of the view). |
It's not only used there: it could be in the footer where page number could appear on the left side, it's what appears in the middle in the SkimTo widget, it's what is part of the bookmark when bookmarking or highlighting... So, I don't think we should think about it only from a visual position point of view.
What do you mean with The books have checked do it that way ? That you did check some paper book ? But a paper book doesn't tell you what chapter is displayed when you have it opened and are reading 2 pages :/ (?)
Will need more opinions on that one :) It's quite a lot more cumbersome to add the blank column (as the setting would have to be forwarded and handled lower in the rendering code - without that, I don't have to, it's just upper in the page number interface)
You mean you're fine with a new chapter may start on the right column ? (Because with page break = page break/blank column means all chapters will start on the left column.) |
Not the target audience (like, at all), but, FWIW: A. First page. |
I'm a possibly somewhat unique form of target audience, namely the large window on desktop type. I also want that in paged media, like Zathura (and just about any other desktop reader, but Zathura feels more similar than Evince or Adobe Reader). But a very mild form of want, or I'd have added it years ago. ;-) |
= use LaTeX xD |
That's an interesting thought ;).
i.e., the behavior in @poire-z's original screenshot, right? |
No problem, let it be a column break. |
:) Nice book, which seems to answer the opposite of what you wrote, doesn't it?: on the right page, it shows the first chapter in this right page (3.10.2...), not the last chapter in this right page (3.10.3...).
I got that. It's the next part of your answer that I didn't get (A new chapter may start on the left side/column, but please not on every pagebrak.) |
So, what are the advantages of Dual Pages over Two Columns in landscape? |
I'm with you at wanting them unified :) mostly for the unification and avoiding the complexities of handling the 2 cases (and fixing the Dual Pages bugs I've seen that would just not be there with Two Columns). |
Yes, the first on the actual (=right) page (but not the first on the actual double page).
I meant: If a new chapter (in LaTex = h1 in html) starts, it would look good, if it would start on the left column/page. But that is not a strong vote. |
Also pinging @WS64 as a dual-page user, about the above questions and discussions. Some other questions to dual page users - can't test that at the moment: how do Reading statistics do with the current dual page, that skips one page number out of two? Do you end up with Page reads = half of the total number of pages? |
This would be helpful for reading certain publications on e-ink readers with 8" or higher screen size.
The text was updated successfully, but these errors were encountered: