Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #561 #568

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Revert #561 #568

merged 1 commit into from
Jun 15, 2024

Conversation

dmalinovsky
Copy link
Contributor

@dmalinovsky dmalinovsky commented Jun 14, 2024

As @Abradoks correctly mentioned, this rule existed for a reason:

This is a common sense typographical rule. "Не" is a negative prefix or particle, so separating it makes the text easy to be misread:

Недопустимы неблагозвучные переносы, а также переносы, ведущие к двусмысленному прочтению текста, способные запутать читателя, привести к недоразумениям, нарушить нормальный процесс чтения. Например, нельзя отделять отрицание «не» от следующего слова или переносить конечный слог «не» какого-либо слова в другую строку, если далее следует глагол
https://print-standart.ru/printing-reference/174-technical-rules-of-typing
https://www.nrap.ru/pub10_90_1_1054.html


This change is Reviewable

@poire-z poire-z merged commit 39ab5d8 into koreader:master Jun 15, 2024
1 check passed
Frenzie pushed a commit to koreader/koreader that referenced this pull request Jun 16, 2024
Includes:
- Russian hyphenation: revert "allow hyphens after не" koreader/crengine#568
- Serbian hyphenation: combine patterns for Cyrillic and Latin scripts koreader/crengine#566
- writeNodeEx(): fix handling of multilines attribute values koreader/crengine#569
  See #12004 (comment).
- Add getBalancedHTML() helper

Also includes:
- kobo: add missing blitbuffer library koreader/koreader-base#1823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants