Fix writeNodeEx(), add getBalancedHTML() #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make them single line in the "extra stream" output giving position of nodes in the main stream, used for handling long-press in the HTML Viewer.
This helper function makes use of our (nearly) conforming HTML parser, which handles unbalanced HTML and builds a proper DOM, and returns the serialized DOM, so balanced. This is currently not used by crengine nor frontend, but it's available for use in HTML dict funcs, where giving balanced HTML to MuPDF can give better rendering.
MuPDF also claims to have an HTML 5 parser since 1.18 btw, so it should do something very similar itself. |
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jun 16, 2024
Includes: - Russian hyphenation: revert "allow hyphens after не" koreader/crengine#568 - Serbian hyphenation: combine patterns for Cyrillic and Latin scripts koreader/crengine#566 - writeNodeEx(): fix handling of multilines attribute values koreader/crengine#569 See #12004 (comment). - Add getBalancedHTML() helper Also includes: - kobo: add missing blitbuffer library koreader/koreader-base#1823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeNodeEx(): fix handling of multilines attribute values
Make them single line in the "extra stream" output giving position of nodes in the main stream, used for handling long-press in the HTML Viewer.
See koreader/koreader#12004 (comment).
Add getBalancedHTML() helper
This helper function makes use of our (nearly) conforming HTML parser (#370), which handles unbalanced HTML and builds a proper DOM, and returns the serialized DOM, so balanced.
This is currently not used by crengine nor frontend, but it's available for use in HTML dict funcs where giving balanced HTML to MuPDF can give better rendering.
I added that to see if it helped with koreader/koreader-base#1586 (comment).
and used it like this:
but it didn't really help: the HTML was bad, and the "balanced" results, although looking more proper, didn't really give anything better.
Anyway, let's have this small helper available, it may help with experimenting and testing.
This change is