[chore] thirdparty patch file dependencies #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going bonkers when a patch file is updated and nothing happens because only CMakeLists.txt is a dependency. This reruns CMake when any file in thirdparty/<dependency> changes. In practice that mostly means *.patch.
poire-z
approved these changes
Nov 18, 2019
|
Just The manual doesn't seem to indicate any other way to exclude directories. https://www.gnu.org/software/make/manual/html_node/Wildcard-Function.html |
|
Do we actually need the wildcard function for a rule prerequisite? The doc seems to hint that wildcards are expanded automatically in rule prereqs. |
|
To my mind I was more or less following the example from the manual: Which example/explanation are you referring to precisely? |
|
The "print" one from https://www.gnu.org/software/make/manual/html_node/Wildcard-Examples.html |
|
D'oh, I must've overlooked that. |
Frenzie
force-pushed
the
patch-dependencies
branch
from
8f166b7
to
3be9f9a
Compare
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Nov 21, 2019
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes koreader#5617.
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Nov 21, 2019
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes #5617.
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes koreader#5617.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going bonkers when a patch file is updated and nothing happens because only CMakeLists.txt is a dependency. This reruns CMake when any file in
thirdparty/<dependency>changes. In practice that mostly means*.patchin addition to CMakeLists.txt. There's acr3.cssin kpvclib and that's probably about it, but I'm trying to be forward-thinking here.