-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[fix] MuPDF Android font dir patch update (#971)" #1013
Conversation
This reverts commit b7dd4c1. Closes <koreader/koreader#5617>.
@NiLuJe I'm a bit confused here. There's something happening only on Cervantes… unrelated to this PR of course so I'll go ahead and merge it now, but pretty weird.
|
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes koreader#5617.
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes #5617.
The Cervantes target tries to build a Debian package, that bit is normal.
As to why it fails, no idea... Ping @pazos ;).
…On Thu, Nov 21, 2019, 14:26 Frans de Jonge ***@***.***> wrote:
Merged #1013 <#1013> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1013?email_source=notifications&email_token=AAA3KZQVQZQR5RWQZGCGBYTQU2EBTA5CNFSM4JQAU3WKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVAICRCQ#event-2819631242>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3KZSHXBAEUY2ZO6UA2MLQU2EBTANCNFSM4JQAU3WA>
.
|
Oh, unless... Because it's no longer pinned on a tag, but on a random commit. I'll look into it (and tag a release soon anyway ;)). |
Ah, no, it's simply that |
It's also highly unclear to me how its error message ( |
git describe has to be able to reach a tag, but the script I wrote only goes deeper than 50 if it fails to checkout the tag or commit. If you've got more than 50 commits since the last tag maybe it's about time? :-P |
Anyway, if it were purely about git describe then surely it should happen just as much on Kobo? |
Yeah, switching to a tag forces an unshallow clone since master is currently 55 commits away from the last tag ;). That particular visible git describe call is Cervantes-specific, but there's another one buried in the Makefile, which is currently probably doing something very stupid, like using the error message as a version string :D. |
(because of a shallow clone, for instance). c.f., koreader/koreader-base#1013
There, fixed it ;). Plus, I'll tag & bump a release soon anyway ;). |
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes koreader#5617.
This reverts commit b7dd4c1.
Closes koreader/koreader#5617.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)