Re-enable HW dithering on Kindle #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only comment tweaks.
This time without fucking up the waveform modes... (The previous attempt was requesting monochromatic dithering on partial/reagl updates, which obviously lead to terrible results). c.f., koreader#819 & koreader#820 As well as koreader/koreader#4602
|
Why, yes, I did just realize that I had made a similar, but not quite the same, mistake in FBInk... :D. |
Because that's highly counter-productive, as the work buffer gets squashed to B&W *before* dithering ^^.
|
Oh, and also don't wreck B&W dithering (applies to Kobo Mk. 7, too). Sidenote: q1 dithering looks like ass, though. But it's free. We shouldn't actually be doing any of that (dithering @ A2/DU) in any active codepath, though, because I think I disabled A2 pans in PDF (because it looked like ass ^^). |
Frenzie
approved these changes
Jan 31, 2020
|
Let's see if I got it right this time :D. |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Feb 4, 2020
* Re-enable HW dithering on Kindle (koreader/koreader-base#1034) * Update SQLite to 3.31.1 (koreader/koreader-base#1035) * reMarkable port (koreader/koreader-base#1023) * zsync2 (koreader/koreader-base#1036)
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Feb 4, 2020
* Switch to zsync2 Requires koreader/koreader-base#1036 * Simplify FBInk syntax The weird-ass workarounds for -s's subopts handling are no longer needed w/ FBInk >= 1.21.0 * Update base * Re-enable HW dithering on Kindle (koreader/koreader-base#1034) * Update SQLite to 3.31.1 (koreader/koreader-base#1035) * reMarkable port (koreader/koreader-base#1023) * zsync2 (koreader/koreader-base#1036) * zsync2 means we can finally have nice things (OpenStack backed storage) * We also no longer need that insane workaround on ARM * And comment out @chrox's mirror, which appears to be down. * Warn that a malformed URL will horribly blow up in fun and interesting ways
yparitcher
added a commit
to yparitcher/koreader-base
that referenced
this pull request
Feb 7, 2020
NiLuJe
pushed a commit
that referenced
this pull request
Feb 7, 2020
This was referenced Feb 19, 2020
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
* Switch to zsync2 Requires koreader/koreader-base#1036 * Simplify FBInk syntax The weird-ass workarounds for -s's subopts handling are no longer needed w/ FBInk >= 1.21.0 * Update base * Re-enable HW dithering on Kindle (koreader/koreader-base#1034) * Update SQLite to 3.31.1 (koreader/koreader-base#1035) * reMarkable port (koreader/koreader-base#1023) * zsync2 (koreader/koreader-base#1036) * zsync2 means we can finally have nice things (OpenStack backed storage) * We also no longer need that insane workaround on ARM * And comment out @chrox's mirror, which appears to be down. * Warn that a malformed URL will horribly blow up in fun and interesting ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without doing something stupid this time around, like requesting monochromatic output when we really, really shouldn't ;).
c.f., #819 & #820
As well as koreader/koreader#4602
This change is