Actually kill HW dithering on Kindle for real ;). #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiLuJe
added a commit
to NiLuJe/koreader-base
that referenced
this pull request
Jan 31, 2020
This time without fucking up the waveform modes... (The previous attempt was requesting monochromatic dithering on partial/reagl updates, which obviously lead to terrible results). c.f., koreader#819 & koreader#820 As well as koreader/koreader#4602
NiLuJe
added a commit
that referenced
this pull request
Jan 31, 2020
* Re-enable HW dithering on Kindle This time without fucking up the waveform modes... (The previous attempt was requesting monochromatic dithering on partial/reagl updates, which obviously lead to terrible results). c.f., #819 & #820 As well as koreader/koreader#4602 * Don't enforce FORCE_MONOCHROME when we're dithering. Because that's highly counter-productive, as the work buffer gets squashed to B&W *before* dithering ^^.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brainfart ;).