Get rid of debug hooks shenanigans #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently horribly broken on CircleCI under Busted, for... reasons. And, surprise surprise, it was originally implemented as... a CI hack. (in 897906d). Plus, I don't think we actually ever set debug hooks in the first place anyway? I fully expect the testsuite to implode on some random new stuff insetad, but, oh, well.
Frenzie
approved these changes
Oct 11, 2020
|
AFAIU, nothing is ever actually setting a hook, so I'm not sure it serves
any purpose now, even at the best of times ;).
…On Sun, Oct 11, 2020, 20:37 Frans de Jonge ***@***.***> wrote:
***@***.**** approved this pull request.
Probably okay, but you could also just say something like debug =
{sethook = function() end} so a human can easily swap it in and out.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1213 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3KZR4HPG6QFWHIPOIQWTSKH3NXANCNFSM4SL4JAEQ>
.
|
|
Also, C BB now ;p.
…On Sun, Oct 11, 2020, 20:38 NiLuJe ***@***.***> wrote:
AFAIU, nothing is ever actually setting a hook, so I'm not sure it serves
any purpose now, even in the best of times ;).
On Sun, Oct 11, 2020, 20:37 Frans de Jonge ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> Probably okay, but you could also just say something like debug =
> {sethook = function() end} so a human can easily swap it in and out.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1213 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA3KZR4HPG6QFWHIPOIQWTSKH3NXANCNFSM4SL4JAEQ>
> .
>
|
Depends a bit, if they're in Really Useful™ positions I tend to prefer keeping such things around for the future over cleaning it up, so to speak. ymmv I suppose |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 11, 2020
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently horribly broken on CircleCI under Busted, for... reasons.
And, surprise surprise, it was originally implemented as... a CI hack.
(in 897906d).
Plus, I don't think we actually ever set debug hooks in the first place
anyway?
I fully expect the testsuite to implode on some random new stuff instead,
but, oh, well.
This change is