-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump FreeType to 2.10.3 #1214
Bump FreeType to 2.10.3 #1214
Conversation
(Shouldn't cause any trouble, I'm pretty much always running FT master on my desktop). |
After this when rebuilding Koreader I have to manually delete
|
That... doesn't surprise me all that much, I rarely do incremental builds for a reason: I don't trust 'em not to mess up the depchain after any significant change ;). |
They almost always work on my end, and ./kodev clean deletes deps downloads so not an option with slow internet. |
I don't rightly recall where the git checkout ends up, so this may be a moot point, but I tend to do those manually, too ;p (e.g., rm -rf base/thirdparty/*/build or something, plus the actual target dir in build/something IIRC). Granted, unmetered cable/FTTLA/FTTH means I've never really thought all that much about the download aspect of things. |
I'm not even sure the buildsystem groks that a version update requires a clean rebuild of at least that subproject? (And I do know that there are... weird interactions where FT & HB are involved when touching 'em on an incremental build). |
usually it does, this time it did download and rebuild FT but i guess it didn't replace the library or something. |
If it doesn't, and that's a pretty big if except for some minor trouble with libk2pdfopt/leptonica/tesseract I never bothered to fix, it's a simple dependency issue in our Makefile. I probably haven't done a full clean build in years on my main Git checkout.
Checkout is separate from build, CMake copies it into build so if you delete build it only needs to recompile, not redownload. But it also does that if the CMakeLists.txt changes or one of the patch files, or one of the dependencies. If it didn't it means FT is a dependency for something that isn't specified properly in Makefile.third. |
@@ -29,7 +29,7 @@ endif() | |||
ko_write_gitclone_script( | |||
GIT_CLONE_SCRIPT_FILENAME | |||
https://gitlab.com/koreader/freetype2.git | |||
VER-2-10-2 | |||
VER-2-10-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, changed cmakelists = this will be recompiled as will everything that depends on FT.
c.f., https://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/CHANGES
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)