Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MXCFB: Match the Kobo behavior for "fast" on every device where I know it'll behave sanely. #1312

Merged
merged 3 commits into from
Feb 21, 2021
Merged

MXCFB: Match the Kobo behavior for "fast" on every device where I know it'll behave sanely. #1312

merged 3 commits into from
Feb 21, 2021

Commits on Feb 21, 2021

  1. MXCFB: Match the Kobo behavior for "fast" on every device where I know 

    it'll behave sanely.

We've effectively switched to DU for "fast" everywhere, and we've
limited our usage of "fast" to plain highlights.
Relying on FORCE_MONOCHROME for these use-cases is unnecessary, and has
known side-effects on various platforms, ranging from minor refresh
glitches to more severe and pernicious issues.

(That leaves PB, which I can't test, and where DU and especially A2
are already special snowflakes to begin with, even on NXP SoCs).
    @NiLuJe
    NiLuJe committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    b9e5261 View commit details
    Browse the repository at this point in the history

  2. Tweak that comment

    @NiLuJe
    NiLuJe committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    da8508c View commit details
    Browse the repository at this point in the history

  3. Comment on what getting rid of FORCE_MONOCHROME changes for us 

    It's highly device & context specific,
but given the fact that A2/DU mangles text no matter what,
I'll take the option that doesn't cause more weird bugs ^^.
    @NiLuJe
    NiLuJe committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    c5786b8 View commit details
    Browse the repository at this point in the history