MXCFB: Match the Kobo behavior for "fast" on every device where I know it'll behave sanely. #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it'll behave sanely. We've effectively switched to DU for "fast" everywhere, and we've limited our usage of "fast" to plain highlights. Relying on FORCE_MONOCHROME for these use-cases is unnecessary, and has known side-effects on various platforms, ranging from minor refresh glitches to more severe and pernicious issues. (That leaves PB, which I can't test, and where DU and especially A2 are already special snowflakes to begin with, even on NXP SoCs).
|
In short: stop requesting |
It's highly device & context specific, but given the fact that A2/DU mangles text no matter what, I'll take the option that doesn't cause more weird bugs ^^.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Feb 21, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Feb 21, 2021
…7325) * Also bump base, because it's mildly related koreader/koreader-base#1312
|
regression: |
NiLuJe
added a commit
that referenced
this pull request
Feb 23, 2021
* Fix a terrible typo in #1312 that used the wrong A2 constant on Zelda/Rex, causing the Reader to get squished to 2bit by FORCE_MONOCHROME. Ouch.
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
…w it'll behave sanely. (koreader#1312) * MXCFB: Match the Kobo behavior for "fast" on every device where I know it'll behave sanely. We've effectively switched to DU for "fast" everywhere, and we've limited our usage of "fast" to plain highlights. Relying on FORCE_MONOCHROME for these use-cases is unnecessary, and has known side-effects on various platforms, ranging from minor refresh glitches to more severe and pernicious issues. (That leaves PB, which I can't test, and where DU and especially A2 are already special snowflakes to begin with, even on NXP SoCs).
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
* Fix a terrible typo in koreader#1312 that used the wrong A2 constant on Zelda/Rex, causing the Reader to get squished to 2bit by FORCE_MONOCHROME. Ouch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've effectively switched to DU for "fast" everywhere, and we've
limited our usage of "fast" to plain highlights.
Relying on FORCE_MONOCHROME for these use-cases is unnecessary, and has
known side-effects on various platforms, ranging from minor refresh
glitches to more severe and pernicious issues.
(That leaves PB, which I can't test, and where DU and especially A2
are already special snowflakes to begin with, even on NXP SoCs).
This change is