MXCFB: Unbreak Zelda/Rex #1314
Merged
MXCFB: Unbreak Zelda/Rex #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful on Kindle Zelda/Rex, where REAGL is sometimes too finicky...
Also, actually check the right A2 constant.
Kindles also suffer from similar FORCE_MONOCHROME quirks, so, keep it disabled there ;).
|
Thanks, that means I can scrap the whole REAGLD idea :D. We've also definitely confirmed that I should stop writing these things at 4AM ^^. |
|
And this much simpler version should still fix all the things ;). |
|
You still left some REAGLD stuff (ZELDA_GLD16) |
|
Yeah, can't hurt leaving the actual flag selection logic in, given how prone I am to forgetting that the Zelda/Rex constants are spelled differently ^^. (This... isn't the first time that same mistake crept in somewhere ^^). |
NiLuJe
changed the title
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Feb 23, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Feb 23, 2021
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
* Fix a terrible typo in koreader#1312 that used the wrong A2 constant on Zelda/Rex, causing the Reader to get squished to 2bit by FORCE_MONOCHROME. Ouch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* One that actually uses REAGLD only on a select few devices, those where REAGL appears extra finicky (right now, Kindle Zelda & Rex).* Re-enable FORCE_MONOCHROME on Zelda & Rex. (Anyway, Rex can be lower res, so it somewhat weighs in the balance, too).This change is