thirdparty: sdcv: update to better support multi-word lookups #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
cyphar
changed the title
cyphar
force-pushed
the
sdcv-multiple-lookups
branch
from
ff4848c
to
7cf9a03
Compare
Frenzie
approved these changes
Oct 9, 2021
cyphar
force-pushed
the
sdcv-multiple-lookups
branch
from
7cf9a03
to
3343994
Compare
|
Maintainer said they will review it in the next week, so we can wait for a week and see if it's merged by then. |
Current sdcv doesn't support multi-word lookups in the most ideal way. In particular, as soon as any word specified in the command-line is found to not have any dictionary results, it immediately bails. This makes sdcv quite hard to use for Japanese deinflection and results in less efficient batching when you have to look up many word candiates. sdcv has been updated upstream to fix this issue, so update to that commit. Ref: Dushistov/sdcv#77 Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
sdcv-multiple-lookups
branch
from
3343994
to
8a7a9c3
Compare
|
Merged upstream. /ping @Frenzie |
cyphar
changed the title
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 22, 2021
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Oct 22, 2021
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
…er#1419) Current sdcv doesn't support multi-word lookups in the most ideal way. In particular, as soon as any word specified in the command-line is found to not have any dictionary results, it immediately bails. This makes sdcv quite hard to use for Japanese deinflection and results in less efficient batching when you have to look up many word candiates. sdcv has been updated upstream to fix this issue, so update to that commit. Ref: Dushistov/sdcv#77 Needed by koreader/koreader#8312. Signed-off-by: Aleksa Sarai cyphar@cyphar.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current sdcv doesn't support multi-word lookups in the most ideal way.
In particular, as soon as any word specified in the command-line is
found to not have any dictionary results, it immediately bails. This
makes sdcv quite hard to use for Japanese deinflection and results in
less efficient batching when you have to look up many word candiates.
The patch applied is fairly trivial and was already submitted upstream
as a PR, so this patch can be dropped once it's merged upstream.
Ref: Dushistov/sdcv#77
Needed by koreader/koreader#8312.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com
This change is