utf8proc: add utf8proc_NFC normalisation wrapper #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Frenzie
approved these changes
Oct 10, 2021
cyphar
force-pushed
the
utf8-normalise
branch
from
5c99d02
to
6f603dc
Compare
poire-z
reviewed
Oct 10, 2021
|
Converted to draft since I might need to add FFI wrappers for a few more utf8proc functions ( |
Useful since Lua doesn't do this natively, and KOReader plugins might need to be able to operate on utf8 strings using Lua's built in string matching which won't match un-normalised strings. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
utf8-normalise
branch
from
6f603dc
to
7dd630a
Compare
|
I don't think any other UTF-8 wrappers are necessary at the moment. As mentioned in other PRs, I will take a look at a rework of the UTF-8 handling in KOReader (which will require a few more wrappers to be provided by koreader-base) but for the Japanese Plugin this is all that is strictly necessary. |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 22, 2021
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Oct 22, 2021
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
Useful since Lua doesn't do this natively, and KOReader plugins might need to be able to operate on utf8 strings using Lua's built in string matching which won't match un-normalised strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful since Lua doesn't do this natively, and KOReader plugins might
need to be able to operate on utf8 strings using Lua's built in string
matching which won't match un-normalised strings.
Useful for koreader/koreader#8312.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com
This change is