-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sdcv to 0.5.4 + a couple of PRs to fix it #1516
Conversation
(Actual in-app lookups work, that was just to double-check the version ;p). |
Since I never actually needed to look into that data ever until today, let's just get rid of the weird debug-specific behavior. Instead, just add a dedicated "Developer options" entry that will dump it on demand (and it'll be sorted to boot, which makes it 500% more usable). Plus, since yesterday's change, the cache format switch between debug or not miiiight actually be crashy, so re-trigger the migration ;p. * Includes a couple of noteworthy base bumps: koreader/koreader-base#1516 (update to sdcv 0.5.4 + fixes pending upstream) koreader/koreader-base#1517 (fix ffiUtil.orderedPairs with keys of mixed types)
Possibly posted in not the right sdcv PR, but I just noticing this today.
It's some bit you get added upstream in Dushistov/sdcv@6e36e77 Everything seems to work, it's just noise in the logs, but still :) |
@poire-z: What's the commandline look like in this instance? EDIT: i.e., do we pass an allow list or a deny list of dictionaries? (I seem to remember that we pass an allow list, but if we passed a deny list, I could just skip the warning for explicitly denied dicts in sdcv ;)). Also, I seem to remember that we didn't/couldn't actually do anything with stderr because io.popen, and this is going to stderr, so I'm a bit puzzled as to how it actually ends up in the logs to begin with? |
Okay, yeah, it's an allow list, so we're stuck handling this on our side... I'd be inclined to leave it as-is, because logging stderr makes sense, but if not, we'd "just" need to throw stderr to /dev/null in the shell command ;). |
Or... we could just patch that out in sdcv, because, while the warnings might make sense upstream, they don't really for us ;). |
I'm not sure if it was actually broken for me before, but at least this one works on both Kobo & Android ;).
@pazos's hunch was nearly perfectly spot-on (my working theory is that it's the
sizeof
comparisons that were broken, quite likely because off64_t vs. ulong, and not the fstat call itself).Split our existing patch in two, and submitted the sanest part of it upstream, because apparently I'd forgotten about it, and it happened to have been reported upstream.
This change is