ffiUtil: Make orderedPairs behave with mixed key types #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually involves sorting numbers with strings, but could theoretically be more esoteric ;). Still assumes that matching types supports comparisons, which may not always be true for custom types without an overloaded operator... Should be fine for our current needs, though.
|
Hasn't broken any of my LuaSettings so far ;p. |
|
And because I'm a genius, only now do I think about checking the references in that function's comment. And, yeah, I didn't reinvent the wheel, so this looks sound ;). |
Frenzie
reviewed
Sep 14, 2022
Unlikely (ha!) to make any difference in Lua, but, oh, well ;).
NiLuJe
commented
Sep 15, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Sep 15, 2022
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Sep 15, 2022
Since I never actually needed to look into that data ever until today, let's just get rid of the weird debug-specific behavior. Instead, just add a dedicated "Developer options" entry that will dump it on demand (and it'll be sorted to boot, which makes it 500% more usable). Plus, since yesterday's change, the cache format switch between debug or not miiiight actually be crashy, so re-trigger the migration ;p. * Includes a couple of noteworthy base bumps: koreader/koreader-base#1516 (update to sdcv 0.5.4 + fixes pending upstream) koreader/koreader-base#1517 (fix ffiUtil.orderedPairs with keys of mixed types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually involves sorting numbers with strings, but could theoretically be more esoteric ;).
Still assumes that matching types supports comparisons, which may not always be true for custom types without an overloaded operator...
Should be fine for our current needs, though.
This change is