Makefile.defs: Use path agnostic bash location for $SHELL #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes koreader not being built on platforms where bash isnt at /bin/bash
Frenzie
approved these changes
Oct 5, 2022
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 5, 2022
|
Do we even use any bashisms btw? |
Baitinq
added a commit
to Baitinq/koreader-base
that referenced
this pull request
Oct 6, 2022
As we just use posix compatible shell scripts. Related koreader#1529
Baitinq
added a commit
to Baitinq/koreader-base
that referenced
this pull request
Oct 6, 2022
As we just use posix compatible shell scripts. Related koreader#1529
I dont think so, I have created an updated pr (#1530) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes koreader not being built on platforms where bash isnt at /bin/bash
This change is