SDL: Fix a bunch of input timeout edge-cases #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may have been passing a float to SDL, which would have had... unexpected results.
non-zero, round the timeout up to 1ms (our lowest supported unit). This prevents a bunch of useless roundtrips in some cases (e.g., autosuspend), because front has higher precision ;).
Frenzie
approved these changes
Oct 24, 2022
|
IIRC, they discourage from using that model (but this one fits very nicely into our own ;p). FWIW, |
NiLuJe
commented
Oct 24, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 24, 2022
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One being a failure to actually round properly, which lead to potentially passing a float to a C function that takes an int; and the other being that SDL's input timeout only has ms precision, which is much coarser than us, which meant that anything > 0 and < 1 ms was asking for an immediate return for as long as that fractional ms ticked. Instead, we now round up to 1ms in these cases.
Goes hand in hand w/ koreader/koreader@d034e1a
This change is