Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL: Fix a bunch of input timeout edge-cases #1541

Merged
merged 4 commits into from
Oct 24, 2022
Merged

SDL: Fix a bunch of input timeout edge-cases #1541

merged 4 commits into from
Oct 24, 2022

Commits on Oct 24, 2022

  1. SDL input: Properly round the timeout value. 

    We may have been passing a float to SDL, which would have had...
unexpected results.
    @NiLuJe
    NiLuJe committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    1eb2368 View commit details
    Browse the repository at this point in the history

  2. Zap debug

    @NiLuJe
    NiLuJe committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    f65a32b View commit details
    Browse the repository at this point in the history

  3. SDL Input: if the requested timeout is below our precision, but 

    non-zero, round the timeout up to 1ms (our lowest supported unit).

This prevents a bunch of useless roundtrips in some cases
(e.g., autosuspend), because front has higher precision ;).
    @NiLuJe
    NiLuJe committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    fc36f5b View commit details
    Browse the repository at this point in the history

  4. Or we can just use ceil in the first place ;o).

    @NiLuJe
    NiLuJe committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    963ab87 View commit details
    Browse the repository at this point in the history