A couple of tweaks #1544
Merged
A couple of tweaks #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the off-chance some wonky kernels out there have a special aversion to discontinuous markers...
|
(Should I bring this one with my bump for xtext and other libs ?) |
|
I don't see why not — it should be 100% harmless. ^_^ |
|
Nah, I'll do it later tonight ;). (I have other unpushed changes behind). |
|
Actually, no, it's good, the rest (if any) will be in the KB PR, so this can go in ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fflush. Necessary forfsyncshenanigans ;).UINT32_MAX. I don't think anything really cares about discontinuous markers, but, better be safe than sorry... (The original intent was to stay low to keep our markers lower than the stock framework on Kindle, but given that you can't find any better kernels than lab126's, it's unlikely to cause any trouble in Kindle-land. Plus, outside of fast mode, which is only used sporadically (read: virtual keyboard), markers are collected differently (via the new wait_for_any ioctl) by the stock framework on Bellatrix anyway, and given that the new Basic is on the Bellatrix platform, lab126 seems to be pretty done with i.MX SoCs ;)).This change is