SDL: Unbreak window state save & restore #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you sure? If my memory doesn't betray me (but it might, I wrote that like five years ago?) the event only occurs when you plug in a controller, while normally it's already plugged in. |
Works for me on Linux w/ a Sony DS4v2, FWIW. |
|
Indeed, I can also confirm that it works on my Hori on SDL 2.26.5. |
Frenzie
approved these changes
Jun 28, 2023
|
Did you want to rebase it into two commits or just squash the whole thing together? |
|
Squash, definitely ;). |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jun 29, 2023
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jun 29, 2023
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix koreader/koreader#10502, regression since #1610
Well, only the size is a regression (plus, it was sortof an ffi/framebuffer API break, even if SDL is quirky in that fb.h / fb.w might not match fb.bb's dimensions because HiDPI shenanigans).
The position one is a bit of a mystery, we get an initial move event no matter what, for some reason, and without the explicit set, it's at the top left despite passing the right stuff to CreateWindow o_O.
Also dropped a duplicate openGameController call, as we handle it via an SDL_CONTROLLERDEVICEADDED event already.
This change is