fix fribidi includes #1616
Merged
fix fribidi includes #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on koreader/crengine#519. |
|
It does not happen right now, but if you're messing with the build system, it's easy to get the wrong include because of it. |
NiLuJe
approved these changes
Jun 11, 2023
benoit-pierre
force-pushed
the
pr/fix_fribidi_includes
branch
from
b1c817d
to
57b2928
Compare
poire-z
approved these changes
Jun 11, 2023
|
No longer needs to be "Draft" ? |
|
Yeah, I was waiting for the macOS check. |
Frenzie
approved these changes
Jun 11, 2023
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jun 29, 2023
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jun 29, 2023
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, using
fribidi/fribidi.hmay result in the wrong (system) include being picked up when building the emulator.This change is