android: refactor full eink updates #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
approved these changes
Dec 21, 2023
ffi/framebuffer_android.lua
Outdated
| end | ||
| -- rockchip rk3x platform | ||
| elseif has_eink_screen and (eink_platform == "rockchip") then | ||
| if not has_eink_screen then return end |
There was a problem hiding this comment.
It always calls updateWindow or whatever it's called for the ANativeWindowBuffer thing?
There was a problem hiding this comment.
There was a problem hiding this comment.
all partial functions have check for has_eink_full_support.
Wouldn't be better use the same pattern for refreshFullImp?
function framebuffer:refreshFullImp(x, y, w, h) -- luacheck: ignore
self:_updateWindow()
if has_eink_screen then
self:_updateFull()
end
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 22, 2023
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with koreader/android-luajit-launcher#451
This change is