-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android: refactor full eink updates #1716
Conversation
ffi/framebuffer_android.lua
Outdated
end | ||
-- rockchip rk3x platform | ||
elseif has_eink_screen and (eink_platform == "rockchip") then | ||
if not has_eink_screen then return end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always calls updateWindow or whatever it's called for the ANativeWindowBuffer thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all partial functions have check for has_eink_full_support.
Wouldn't be better use the same pattern for refreshFullImp?
function framebuffer:refreshFullImp(x, y, w, h) -- luacheck: ignore
self:_updateWindow()
if has_eink_screen then
self:_updateFull()
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
Goes with koreader/android-luajit-launcher#451
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)