ffi/framebuffer_mxcfb.lua: Fix Night Mode on Kobo Elipsa 2E #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit "fixes" reported graphical problems caused by switching to Night Mode on Elipsa 2E. Mentioned here: koreader/koreader#10719 (comment)
|
|
|
IIRC, we've confirmed that Nickel does use the Eclipse waveform modes explicitly and not AUTO and that... it works there, so I'm still mostly stumped ;p. Since the slew of new devices run on the same SoC, at least we'll have more opportunities to test stuff soon... |
|
@NiLuJe Does that mean to merge now? |
|
The opposite, I'd rather wait and see how the new devices fare with the current behavior (... assuming the ioctls are compatible ;p). |
|
Completely unrelated query for @katadelos, given the MTK stuff happening with the new devices: Aren't gyro-triggered rotations inverted on the Elipsa 2E? |
NiLuJe
added a commit
that referenced
this pull request
May 9, 2024
* Bump LuaJIT to 20240422 (there's a potentially interesting 20-year old memory leak fixed) * Update FBInk & KoboUSBMS to handle the new devices properly * Update MTK headers for whatever we could glean of the new stuff * Add dedicated refresh modes for Kaleido-specific waveform modes (basically, once for images, and one for text/highlights). * Implemented a halfway sensible wait_for logic for those new devices * Special-cased the Elipsa 2E because it behaves differently. * "Fix" nightmode on the Elipsa 2E (thanks to #1768). * And, as usual, workaround a few driver bugs in the process (as far as possible) ;p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit "fixes" reported graphical problems caused by switching to Night Mode on Elipsa 2E.
Mentioned here: koreader/koreader#10719 (comment)
This change is