-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for NTX + MTK + Kaleido devices #1779
Conversation
Initial support for MTK devices
Support for the new MTK Kobo devices
Useful for kaleido panels, which tend to prefer GCC16 over GC16 for image content
We only use it for the VK highlights, and we don't need dithering there. We might actually want to drop it from DU, to be perfectly honest...
As it appears to behave slightly differently than its later brethren
Which is to wait *after* sending an update, rather than *before* Which, admittedly, makes more sense, at least semantically ;).
(... except on the Elipsa 2E)
Fix some more MTK issues
Workaround an apparent off-by-one... somewhere in the driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @NiLuJe)
ffi/framebuffer_mxcfb.lua
line 296 at r1 (raw file):
-- c.f., epdc_process_update @ drivers/video/fbdev/mxc/mxc_epdc_v2_fb.c on a Kobo Mk. 7 kernel...). -- And regardless of alignment constraints, make sure the rectangle is strictly bounded inside the screen. x, y, w, h = bb:getBoundedRect(x, y, w, h, dither and 8 or fb.alignment_contraint)
Looks like a typo, one that's older I assume but still distracting
LuaJIT changes for those interested: |
Could this be included NiLuJe/FBInk#78? There's a similar patch for kobo-usbms: https://github.com/benoit-pierre/koreader-base/blob/dev/thirdparty/kobo-usbms/fix_make_-n.patch |
Err, where? |
Welp. Somehow managed to miss email notification for this, my bad. |
contrain vs constrain ;-) |
Oh, yeah, that one's new, lol ;D. |
Merge @benoit-pierre's patch, and fix Kindle FBInk build
(Yay for code completion, they all matched :D).
Fix behavior when running after Nickel's already started a USBMS session once (i.e., make it work :D)
It's unhelpful and often horribly outdated anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 8 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Frenzie)
ffi/framebuffer_mxcfb.lua
line 296 at r1 (raw file):
Previously, Frenzie (Frans de Jonge) wrote…
Looks like a typo, one that's older I assume but still distracting
Done.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)