Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: make certificates bundle generation more robust #1778

Merged
merged 1 commit into from
May 3, 2024

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented May 3, 2024

Don't use the default build system rule to create the certificates bundle: connections to hg.mozilla.org from CIs seem to be flaky, resulting in regular failures.

Cf. https://curl.se/docs/caextract.html


This change is Reviewable

@benoit-pierre benoit-pierre marked this pull request as draft May 3, 2024 19:30
Don't use the default build system rule to create the certificates
bundle: connections to `hg.mozilla.org` from CIs seem to be flaky,
resulting in regular failures.

Cf. https://curl.se/docs/caextract.html
@benoit-pierre
Copy link
Contributor Author

Updated to fetch the bundle as part of the download step, and to only show a warning if it can't be updated: this was the only remaining thing preventing some platform offline builds after make download with the new build system.

@benoit-pierre benoit-pierre marked this pull request as ready for review May 3, 2024 20:44
@Frenzie Frenzie merged commit 9a90ea8 into koreader:master May 3, 2024
1 check passed
@benoit-pierre benoit-pierre deleted the pr/ca-bundle_robustness branch May 3, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants