add support for luarocks3 from brew #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not an issue that this also drops support for the older version? |
|
@Frenzie: It will break compatibility with luarocks 2.4, but you'll only need to do |
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Dec 13, 2018
* [build, MacOS] Add support for luarocks3 from brew (koreader/koreader-base#774) @pazos * [fix] Android nightmode landscape (koreader/koreader-base#776) @Frenzie Fixes koreader#3945.
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Dec 13, 2018
Includes: * [build, MacOS] Add support for luarocks3 from brew (koreader/koreader-base#774) @pazos Fixes #4375. * [fix] Android nightmode landscape (koreader/koreader-base#776) @Frenzie Fixes #3945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes koreader/koreader#4375. (the build error w/ luarocks-5.1 not available).
Needs review because I'm dumb 👍