Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Android nightmode landscape #776

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Dec 13, 2018

Forgot to set rotation on the second blitbuffer. Fixes koreader/koreader#3945.

Forgot to set rotation on the second blitbuffer. Fixes koreader/koreader#3945.
@Frenzie Frenzie added the bug label Dec 13, 2018
@Frenzie Frenzie merged commit a6b824b into koreader:master Dec 13, 2018
@Frenzie Frenzie deleted the fix-android-nightmode-portrait branch December 13, 2018 19:04
Frenzie added a commit to Frenzie/koreader that referenced this pull request Dec 13, 2018
* [build, MacOS] Add support for luarocks3 from brew
(koreader/koreader-base#774) @pazos
* [fix] Android nightmode landscape (koreader/koreader-base#776) @Frenzie

Fixes koreader#3945.
Frenzie added a commit to koreader/koreader that referenced this pull request Dec 13, 2018
Includes:

* [build, MacOS] Add support for luarocks3 from brew
(koreader/koreader-base#774) @pazos 
Fixes #4375.
* [fix] Android nightmode landscape (koreader/koreader-base#776) @Frenzie 
Fixes #3945.
@poire-z
Copy link
Contributor

poire-z commented Dec 13, 2018

Nice!
Just curious, why did you not have the issue on your phone and on the android emulators? And how did you finally find it out?

@Frenzie
Copy link
Member Author

Frenzie commented Dec 13, 2018

I must've accidentally run a customized version last time, probably one with this line or something functionally equivalent that I forgot to commit. >_>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants