Log something useful if SDL2 fails to init #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Thanks to @ptrm ;)).
|
All in all, a great showing :D. I'll fix that, thanks ;). |
Frenzie
reviewed
Feb 11, 2019
| @@ -68,7 +68,7 @@ function S.open() | |||
| if SDL.SDL_Init(bit.bor(SDL.SDL_INIT_VIDEO, | |||
| SDL.SDL_INIT_JOYSTICK, | |||
| SDL.SDL_INIT_GAMECONTROLLER)) ~= 0 then | |||
| error("Cannot initialize SDL.") | |||
| error("Cannot initialize SDL: " .. ffi.string(SDL.SDL_GetError())) | |||
There was a problem hiding this comment.
Fun fact: I added the FFI header for it but I don't recall what I debugged with it. (Definitely not this line, 'cause I wouldn't have cleaned that out.)
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Feb 14, 2019
koreader/koreader-base#814 necessary for koreader#4591 Also includes koreader/koreader-base#809 koreader/koreader-base#808 and koreader/koreader-base#810
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Feb 14, 2019
koreader/koreader-base#814 necessary for #4591 Also includes koreader/koreader-base#809 koreader/koreader-base#808 and koreader/koreader-base#810
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Thanks to @ptrm ;)).