-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate ghosting on eInk when showing an image ScreenSaver #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Not that clear() is implemented anywhere else, but, still).
Frenzie
reviewed
Feb 14, 2019
@@ -176,7 +176,7 @@ function Device:onPowerEvent(ev) | |||
logger.dbg("Already in screen saver mode, suspending...") | |||
self:rescheduleSuspend() | |||
end | |||
-- else we we not in screensaver mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weeeeeee! 🥂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Feb 14, 2019
koreader/koreader-base#814 necessary for koreader#4591 Also includes koreader/koreader-base#809 koreader/koreader-base#808 and koreader/koreader-base#810
Frenzie
added a commit
that referenced
this pull request
Feb 14, 2019
koreader/koreader-base#814 necessary for #4591 Also includes koreader/koreader-base#809 koreader/koreader-base#808 and koreader/koreader-base#810
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
…oreader#4591) * Flash a white screen before showing a screensaver image, to prevent ghosting. * Really limit the white flash to full-screen images * Limit that behavior to eInk screens (Not that clear() is implemented anywhere else, but, still).
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By flashing to a white screen first.
Depends on koreader/koreader-base#814