Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate ghosting on eInk when showing an image ScreenSaver #4591

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Feb 14, 2019

By flashing to a white screen first.

Depends on koreader/koreader-base#814

@NiLuJe
Copy link
Member Author

NiLuJe commented Feb 14, 2019

@@ -176,7 +176,7 @@ function Device:onPowerEvent(ev)
logger.dbg("Already in screen saver mode, suspending...")
self:rescheduleSuspend()
end
-- else we we not in screensaver mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weeeeeee! 🥂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@Frenzie Frenzie merged commit 134998a into koreader:master Feb 14, 2019
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
…oreader#4591)

* Flash a white screen before showing a screensaver image, to prevent
ghosting.

* Really limit the white flash to full-screen images

* Limit that behavior to eInk screens

(Not that clear() is implemented anywhere else, but, still).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants