[fix] Makefile.defs: add sqlite to CMAKE_THIRDPARTY_LIBS #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it won't get cleaned by `make clean` or `make dist-clean`. Also make it a little more ordered & legible.
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Mar 17, 2019
Just a passing thought, putting it up in a PR on GH for public archival/inspiration purposes or possibly to extend upon. This is a proof of concept of building in thirdparty/build/$(MACHINE) instead of thirdparty/build/$DEPENDENCY/$(MACHINE). That way instead of using the Makefile.third with a lot of complex variable passing to CMake etc. you'd keep the logic almost entirely in CMake (not implemented in this proof of concept), so you should be able to write things like `add_dependencies(mupdf zlib)`. Also the dist-clean command could be simplified to removing `THIRDPARTY_BUILD_DIR`. Or to put it another way, if you're using CMake you might as well actually use it, so that errors like koreader#865 can't occur.
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Mar 17, 2019
Just a passing thought, putting it up in a PR on GH for public archival/inspiration purposes or possibly to extend upon. This is a proof of concept of building in thirdparty/build/$(MACHINE) instead of thirdparty/build/$DEPENDENCY/$(MACHINE). That way instead of using the Makefile.third with a lot of complex variable passing to CMake etc. you'd keep the logic almost entirely in CMake (not implemented in this proof of concept), so you should be able to write things like `add_dependencies(mupdf zlib)`. Also the dist-clean command could be simplified to removing `THIRDPARTY_BUILD_DIR`. Or to put it another way, if you're using CMake you might as well actually use it, so that errors like koreader#865 can't occur.
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Mar 17, 2019
Like koreader#865 but only occurs when cross-compiling for certain platforms. Cf. koreader#866 for a possible solution where this could never be a problem.
Frenzie
added a commit
that referenced
this pull request
Mar 17, 2019
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Mar 18, 2019
Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Mar 18, 2019
Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Mar 18, 2019
* Properly account for MuPDF feeding us premultiplied alpha * Bump base to pickup necessary backend changes Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
…ader#4807) * Properly account for MuPDF feeding us premultiplied alpha * Bump base to pickup necessary backend changes Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it won't get cleaned by
make cleanormake dist-clean.Also make it a little more ordered & legible.