[chore] CMake: deprecate custom processor count logic #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 3 shipped with a built-in module. Also quote `KO_DOWNLOAD_DIR`.
|
Today it looks like this: https://github.com/Kitware/CMake/blob/283330976f2379eec214bfe1d51a27c29cc1f8fc/Modules/ProcessorCount.cmake For 3.5 it looks like this: https://github.com/Kitware/CMake/blob/64130a7e793483e24c1d68bdd234f81d5edb2d51/Modules/ProcessorCount.cmake Either way, same idea but more complete with "automatic" updates & improvements. |
NiLuJe
approved these changes
Mar 17, 2019
| include(ProcessorCount) | ||
| ProcessorCount(N) | ||
| # 0 if unknown | ||
| set(PROCESSOR_COUNT ${N}) |
There was a problem hiding this comment.
I'm assuming N falls-back to 0, right? ;).
There was a problem hiding this comment.
Yes it does (reading the links provided helps. :D).
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Mar 18, 2019
Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Mar 18, 2019
Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Mar 18, 2019
* Properly account for MuPDF feeding us premultiplied alpha * Bump base to pickup necessary backend changes Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
…ader#4807) * Properly account for MuPDF feeding us premultiplied alpha * Bump base to pickup necessary backend changes Also includes a bunch of CMake refactoring (koreader/koreader-base#865 koreader/koreader-base#867 koreader/koreader-base#868)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 2.8.5 shipped with a built-in module.
Also quote
KO_DOWNLOAD_DIR.