[chore] Update CMake to modern style with lowercase commands #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As luck would have it, modern post-2012 preferred CMake style agrees with my own sensibilities, but it's mainly the consistency that concerns me. I didn't have to come up with anything from scratch. I simply ran the two commands given in these two commits: * <https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=77543bd>. > Ancient CMake versions required upper-case commands. Later command names became case-insensitive. Now the preferred style is lower-case. * <https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9db31162>. > Ancient versions of CMake required else(), endif(), and similar block termination commands to have arguments matching the command starting the block. This is no longer the preferred style.
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Mar 21, 2019
See koreader#4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Mar 21, 2019
See #4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
See koreader#4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As luck would have it, modern post-2012 preferred CMake style agrees with my own sensibilities, but it's mainly the consistency that concerns me.
I didn't have to come up with anything from scratch. I simply ran the two commands given in these two commits:
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=77543bd.
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9db31162.