-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Add util.ffiLoadCandidates to try multiple SDL2 library names #873
Conversation
Fixes <koreader/koreader#4826 (comment)>. A bit like the idea penned down [here](koreader/koreader#3108 (comment)).
cc3abe7
to
e875c96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binary distro be stupid.
LGTM! ;).
Fixes minor typo with embarrassing consequences from koreader#873 The file I committed accidentally wasn't 100 % the same as the one I tested. That would've blown up in a pretty embarrassing way.
Fixes minor typo with embarrassing consequences from #873 The file I committed accidentally wasn't 100 % the same as the one I tested. That would've blown up in a pretty embarrassing way.
See koreader#4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
See #4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Unfortunately, even with this fix, I ran into the missing libSDL.so issue. I'm running a Void Linux chroot, and the problem is that it ships libraries with version strings in the filename: e.g. |
No symlinks of any sort? On my Debian On older versions it's the same, except on Ubuntu 16.04, for example, the actual library is
|
Looks like I've just got |
Alright, so then we can add |
As proposed but forgotten to add in <koreader#873 (comment)>. Fixes <koreader/koreader#5122>.
As proposed but forgotten to add in <#873 (comment)>. Fixes <koreader/koreader#5122>.
See koreader#4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Fixes koreader/koreader#4826 (comment).
A bit like the idea penned down here.