[fix] MuPDF Android font dir patch update #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiLuJe
reviewed
Sep 9, 2019
| +char * | ||
| +get_font_file_android(char *name) | ||
| +{ | ||
| + char *fontdir; |
There was a problem hiding this comment.
const char fontdir[] = "/system/fonts";
size_t len = sizeof(fontdir) + strlen(name) + 1; // sizeof on a string literal includes the NUL
char *filename = malloc(len);
if (filename == NULL) {
return NULL;
}(Fairly minor, this works ;)).
There was a problem hiding this comment.
I'm pretty sure I tested with what I thought of as a stress test (EPUB) but I guess that just used the Times (or whatever) that's bundled with MuPDF. In any case I didn't have any HTML dictionaries installed on the emulator.
There was a problem hiding this comment.
You're fine with the basic principle besides this nit? :-P
Frenzie
commented
Sep 9, 2019
| @@ -68,7 +68,7 @@ index f6951ba2..b1fdd981 100644 | |||
| /* | |||
| Base 14 PDF fonts from URW. | |||
| Noto fonts from Google. | |||
| @@ -367,3 +371,185 @@ fz_lookup_noto_emoji_font(fz_context *ctx, int *size) | |||
| @@ -367,3 +371,188 @@ fz_lookup_noto_emoji_font(fz_context *ctx, int *size) | |||
There was a problem hiding this comment.
@NiLuJe Apparently I thought your suggestion took off more lines than it did? :-P Oh well, luckily there's the CI.
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Sep 9, 2019
koreader/koreader-base#971 Fixes <koreader#5347 (comment)>. Also includes: * [feat] Add FFI RTC interface (koreader-base#969) * Bump thirdparty/djvulibre to current master (koreader-base#970)
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Sep 9, 2019
koreader/koreader-base#971 Fixes <#5347 (comment)>. Also includes: * [feat] Add FFI RTC interface (<koreader/koreader-base#969>) * Bump thirdparty/djvulibre to current master (<koreader/koreader-base#970>)
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Nov 21, 2019
This reverts commit b7dd4c1. Closes <koreader/koreader#5617>.
Frenzie
added a commit
that referenced
this pull request
Nov 21, 2019
This reverts commit b7dd4c1. Closes <koreader/koreader#5617>.
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
koreader/koreader-base#971 Fixes <koreader#5347 (comment)>. Also includes: * [feat] Add FFI RTC interface (<koreader/koreader-base#969>) * Bump thirdparty/djvulibre to current master (<koreader/koreader-base#970>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. koreader/koreader#5347 (comment).