Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: add HTML validation #38

Closed
wants to merge 1 commit into from

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Dec 2, 2023

Follow-up to #37.


This change is Reviewable

Copy link

github-actions bot commented Dec 2, 2023

@Frenzie
Copy link
Member Author

Frenzie commented Dec 2, 2023

I'm not entirely convinced about this specific action. It's complaining about things that don't matter to Weblate and it doesn't seem to be aware of things that simply exist:

"file:/github/workspace/user_guide/index.html":36.30-36.36: error: CSS: Parse Error.
"file:/github/workspace/user_guide/index.html":186.19-186.24: error: CSS: "break-before": "always" is not a "break-before" value.

I'll leave the PR here as an archive in case I change my mind, but closing for now.

@Frenzie Frenzie closed this Dec 2, 2023
@Frenzie Frenzie deleted the validate branch December 2, 2023 20:21
Frenzie added a commit to Frenzie/koreader.github.io that referenced this pull request Dec 3, 2023
Required for <koreader/koreader#11147 (comment)>.

Turns out most of what <koreader#38> was complaining about was relevant after all.
Frenzie added a commit that referenced this pull request Dec 3, 2023
Required for <koreader/koreader#11147 (comment)>.

Turns out most of what <#38> was complaining about was relevant after all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant