New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Guide Maintenance #11147
Comments
CONTRIBUTING TO THE USER GUIDE✅ If you are not changing anything, you can skip this message and write in this thread directly. Our user guide is written by a single person (me) with the feedback of devs. If you want to change something in the guide, you should first write in this thread:
Changes that are welcome
Changes that you should be careful about
Any of the changes proposed in this second group should follow the Web Content Accessibility Guidelines, especially in contrast and readability areas. And you should be able to explain how your change improves the readability, based on design and usability principles. Also if you propose a change to the colors, you should provide a palette which has enough contrast and separation and that is also optimized for color blindness. Please only suggest a change if you are sure that it will improve the experience of the users reading this guide.
|
I would like to contribute to translation of the user guide. Where can I find some kind of template for translation, please? |
Nothing of the sort exists as of yet, but it should be possible to add it to Weblate. |
Great. I'm looking forward to it :) |
I guess that you want to contribute Slovak translation since you added the Slovak keyboard before. I just checked the user guide page translated into Slovak with Google Translate. I looked at random parts and to my surprise they are pretty good (I try to keep sentences short and clear in the English version for our non-English users so that helped maybe). Please have a look yourself. Only possible problem might be menu items in green text. So what I am saying is, instead of translating all of the guide yourself (which is a substantial effort), you can just proofread a Google translated version which would be much easier. |
As a quick note on that front, I find that DeepL and perhaps also ChatGPT 3/4 provide a higher quality, more natural translation than Google. But I say that mainly on the basis of Dutch/English/German/French; it might be different for Slovak. |
A good idea in genral, specifically required for Weblate. See <koreader/koreader#11147 (comment)>.
A good idea in general, but required for Weblate. See <koreader/koreader#11147 (comment)>.
@offset-torque: yes, I meant translation to Slovak |
It was missing but now I checked again and DeepL added Slovak it seems. Slovak language is generally missing from all translation services/models. Closest thing you can find is Czech language instead, which is very similar to Slovak so they don't bother with a smaller language I guess. GPT3 was prone to hallucinating in Slovak because of sparse training data I think. I haven't checked GPT4 yet. Maybe we can add some kind of translate widget to the user guide page like some websites do, so users can translate it on the fly to their language. What do you think Frenzie ? Better than nothing I guess, but I don't know the downsides (Also I don't know how good it is for CJK languages). |
I'm inclined to think people can enter the link in Google Translate themselves if they want to, but if you want they made it simple to add. |
Required for <koreader/koreader#11147 (comment)>. Turns out most of what <koreader#38> was complaining about was relevant after all.
Required for <koreader/koreader#11147 (comment)>. Turns out most of what <#38> was complaining about was relevant after all.
@offset-torque It looks like I'll have to rename it to |
Whichever one you see appropriate, Frenzie. You know this system better than me. |
This side of Weblate is all new to me too. But I'll make it |
@sonix-github https://hosted.weblate.org/projects/koreader/user-guide/ now exists. Please let me know if you see anything strange. |
Thanks @Frenzie It seems OK. Im going to start the translation to Slovak language |
Will this translation survive if the change It feels it may be too early to start tranlating this big html file: it feels it needs some bit of cleaning and normalisation with proper class names instead of inline CSS, and maybe more line breaks in the source file to expose translatable text from the HTML noise, which would make the strings available to translators also simpler. |
I agree with what poire-z said. Although I tried to use classes to make changes easier later, some "style" exceptions exist like that example. Also I didn't think about translation compatibility so yes it can be optimized to make translator's job easier. I am sure things can be more elegant but my CSS knowledge is very basic so any help/suggestion is welcome. |
I am familiar with basic HTML syntax, therefore I am aware of preserving the tags. I can also contribute to translation of PDF user guide to Slovak language. |
I guess you are, but other translators might not be :) |
You are right @poire-z so I am going to "stand-by" mode with translations :) |
Right. Toc, Alt ToC : all good, no comment.
👍 on the explanations and how to for hidden flows !
The ConfirmBox text says:
No real problem, just user taste :) Discussed/argued all along #10193. |
I think it's clear. 👍 It may or may not read a little bit better changed like this, but feel free to keep it as is.
|
Right. No more comments, all is okay, thank you. |
Allow me to clarify that I neither wanted nor asked for an alt theme. My only gripe with the standard design was that the chapter boundaries were not clearly discernible. It is hard to tell where one chapter ends and where the next one begins (at least for me). And as the chapter names are repeated on each new line, it results in tedious rereading of the same chapter titles over and over again. @poire-z graciously offered to create an alternative theme with alternating background shading (one of several suggested design elements), which solves the aforementioned issue as the eye can effortlessly skip to the next chapter without re-reading like-named title bars, is beautiful to look at, and of course I appreciate very much 👍 💯 |
Thanks for the feedback folks. All suggestions applied/corrected/integrated. Exception below:
Are you sure poire-z? Custom flows are removed from my Progress bar as seen in the image below. And yes, they are visible in the Skim widget, I just added this to the guide. But now I noticed that Skim widget is problematic because custom flows before the current page become totally invisible, which makes it impossible to jump to a previous custom flow. That needs fixing I think. Maybe they can be white to indicate empty spaces. Marked area is a Custom flow but indistinguishable here: @jonnyl2 |
Oh, indeed. And when you jump to a page in a hidden flow, the progress bar resets (restart at 0, and spans only this hidden flow). Once you reach the end of that hidden flow (so, progress bar filled), next tap, going back into the main flow, restores the original book-spanning progress bar.
I notice that too. In that PR, it seems they were shown, in a darker nearly black dark gray. Dunno if it changed or if it's an effect of gray/alpha/dim/darken blitbuffer stuff. Maybe for @NiLuJe (who also cared about these Progress widget) to look at it. |
@poire-z and @Frenzie |
Looks fine to me.
Some ideas:
It's juste the extension .epub or .html that are not accepted. .txt and .zip are find. Some people rename their epub to .zip. But yes, safer to mention to zip it.
Sure. I think there are probably others (but no time to look for the most interesting ones). |
Imo it's just fast period, not "reasonably" fast. :-) Put another way, I effectively never have a document take more than 2-3 seconds to load on my decade-old H2O (with kerning: best!), much faster still on my Libra 2, and page turning is extremely fast.
I don't know if it's worth going into details, but it's really just on a page by page basis for PDF.
This is only for reflow, so maybe the header should say something like
It'd be a bit more diplomatic to say something more neutral like
Maybe it's too nitty gritty, but running
Can't hurt. |
Sample issue where |
I made all the additions/corrections to the slow book section.
I corrected this as you wrote Frenzie, but that last book had a ~800 KB CSS. I read whole series smaller than that :) You can have a look at this if you have time, Solutions part changed mainly. Also @hius07 and @mergen3107. If you have your own tips/tricks/solutions in addition to the ones in this PDF, please tell. |
Sure, but that's an exceptional situation. There's a wide range below that where it's excessive but not quite abusive. ;-) I have no further comments at this time. |
Looks fine to me, except:
|
Quick question: Is it "Quick Menu" or "QuickMenu". |
It seems to be called QuickMenu, though that might just come from code without much thought behind it otherwise (where it's necessarily QuickMenu, unless you do something awkward like Quick_Menu). But I think it's fine to keep it. koreader/plugins/gestures.koplugin/main.lua Line 249 in 3e7ab19
koreader/plugins/profiles.koplugin/main.lua Line 131 in 3e7ab19
|
24.02 Guide Update ChangelogFirst update of the year. On one hand I am glad that the project is constantly improving, on the other hand I have to document all these improvements :) I am not sure (because we don't have pages anymore) but the guide is now around 75 pages which makes it probably one of the best documented open source applications. NOTE: We now have a "If your book is slow" section, just under the Troubleshooting section. You can directly link to this, if someone opens an issue complaining about a slow book (so you don't have to explain everything repeatedly). I also made lots of style changes, so the guide should look tidier, more professional and prettier. Have fun ! New sections:
Added:
Updated:
Guide style changes
|
https://koreader.rocks/user_guide/#bookmarks under "Editing a highlight" you may want to specify adjusting only works with epub files. #11519 |
"with reflowable documents" |
@elandorr - Thanks, I will add that. |
Export Highlights plugin <- that section needs a further explanation either by pointing to Highlight-export or explaining how to set up each service in detail - ie memos service needs |
@cpuks - I didn't even know this wiki page exists, no one told me :) I will add that info to the guide and also provide a link to that page just in case. Thanks. |
@offset-torque yeah same - I mean I’ve seen it couple times but yesterday after two hours I found out what URL means for memos export - worst part that it didn’t help anyway. |
@Frenzie My question: Is there a lockout procedure in github that signalizes that the file is being edited by someone so others shouldn't make changes until it is released by the current editor (to avoid conflicts and messy diffs). So for example you want to make a change, first I merge my changes then you can work on it. How is this coordination done? Although not many people are editing the guide, it is good to know the correct procedure. |
As far as us here are concerned what you just did is the procedure. You could do it a bit more publicly in a draft PR if you're comfortable airing your dirty laundry, or split it up into slightly smaller edits (e.g., per section). Maybe adding a notice to the README file is an option if you implicitly meant you're mostly worried about people who don't follow this thread. |
Got it, thanks. Since I have to test every little change (sometimes in multiple browsers) to be sure that it renders as intended, draft PR option is impossible. I guess more frequent edits is the way. |
24.03 Guide Update ChangelogMinor update with small additions. Content updates
Style and code updates
|
Changelog is here: koreader/koreader#11147 (comment)
ATTENTION PLEASE: This thread carries on from the original user guide discussion thread.
Archived original thread covers the discussions for the PDF version and can be found here: #8058
The text was updated successfully, but these errors were encountered: