Skip to content

Commit

Permalink
Shellcheck spanked me.
Browse files Browse the repository at this point in the history
  • Loading branch information
@NiLuJe
NiLuJe committed Apr 14, 2018
1 parent 86933b8 commit 4e9834c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions platform/kobo/nickel.sh
View file
Expand Up @@ -16,8 +16,8 @@ export LD_LIBRARY_PATH="/usr/local/Kobo"
# NOTE: That check is possibly wrong on PLATFORM == freescale (because I don't know if the sdio_wifi_pwr module exists there), but we don't terribly care about that.
if lsmod | grep -q sdio_wifi_pwr; then
killall udhcpc default.script wpa_supplicant 2>/dev/null
[ "${WIFI_MODULE}" != "8189fs" ] && wlarm_le -i ${INTERFACE} down
ifconfig ${INTERFACE} down
[ "${WIFI_MODULE}" != "8189fs" ] && wlarm_le -i "${INTERFACE}" down
ifconfig "${INTERFACE}" down
# NOTE: Kobo's busybox build is weird. rmmod appears to be modprobe in disguise, defaulting to the -r flag. If re-specifying -r starts to fail one day, switch to rmmod without args, or modprobe -r.
rmmod -r "${WIFI_MODULE}"
# c.f., #2394?
Expand Down

4 comments on commit 4e9834c

@Frenzie
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I haven't updated shellcheck in a while, it's got some new checks so you might want to check it on https://www.shellcheck.net/ or locally as well ;-)

@NiLuJe
Copy link
Member Author

@NiLuJe NiLuJe commented on 4e9834c Apr 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks ;).

@NiLuJe
Copy link
Member Author

@NiLuJe NiLuJe commented on 4e9834c Apr 14, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Now I remember why I don't have a local copy installed:

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] dev-lang/ghc-8.0.2:0/8.0.2::gentoo  USE="gmp profile -binary -doc -ghcbootstrap -ghcmakebinary" 138,224 KiB
[ebuild  N     ] app-admin/haskell-updater-1.2.12-r1::gentoo  27 KiB
[ebuild  N     ] dev-haskell/cabal-1.24.2.0:0/1.24.2.0::gentoo  USE="-profile {-test}" 432 KiB
[ebuild  N     ] dev-haskell/transformers-0.5.2.0:0/0.5.2.0::gentoo  USE="-doc -hscolour -profile" 34 KiB
[ebuild  N     ] dev-haskell/binary-0.8.3.0:0/0.8.3.0::gentoo  USE="-doc -hscolour -profile {-test}" 51 KiB
[ebuild  N     ] dev-haskell/random-1.1:0/1.1::gentoo  USE="-doc -hscolour -profile {-test}" 11 KiB
[ebuild  N     ] dev-haskell/syb-0.5.1:0/0.5.1::gentoo  USE="-doc -hscolour -profile {-test}" 39 KiB
[ebuild  N     ] dev-haskell/bytestring-builder-0.10.8.1.0:0/0.10.8.1.0::gentoo  USE="-profile" 43 KiB
[ebuild  N     ] dev-haskell/tagged-0.8.4:0/0.8.4::gentoo  USE="-doc -hscolour -profile" 10 KiB
[ebuild  N     ] dev-haskell/mtl-2.2.1-r1:0/2.2.1::gentoo  USE="-doc -hscolour -profile" 16 KiB
[ebuild  N     ] dev-haskell/text-1.2.2.1:0/1.2.2.1::gentoo  USE="-doc -hscolour -profile {-test}" 147 KiB
[ebuild  N     ] dev-haskell/primitive-0.6.1.0-r1:0/0.6.1.0::gentoo  USE="-doc -hscolour -profile {-test}" 13 KiB
[ebuild  N     ] dev-haskell/parsec-3.1.11:0/3.1.11::gentoo  USE="-doc -hscolour -profile {-test}" 32 KiB
[ebuild  N     ] dev-haskell/hashable-1.2.4.0:0/1.2.4.0::gentoo  USE="-doc -hscolour -profile {-test}" CPU_FLAGS_X86="sse2 sse4_1" 24 KiB
[ebuild  N     ] dev-haskell/regex-base-0.93.2-r1:0/0.93.2::gentoo  USE="-doc -hscolour -profile" 9 KiB
[ebuild  N     ] dev-haskell/tf-random-0.5:0/0.5::gentoo  USE="-profile" 19 KiB
[ebuild  N     ] dev-haskell/nats-1:0/1::gentoo  USE="hashable -profile" 6 KiB
[ebuild  N     ] dev-haskell/json-0.9.1:0/0.9.1::gentoo  USE="generic parsec pretty -doc -hscolour -mapdict -profile" 23 KiB
[ebuild  N     ] dev-haskell/regex-tdfa-1.2.2:0/1.2.2::gentoo  USE="-doc -hscolour -profile" 65 KiB
[ebuild  N     ] dev-haskell/unordered-containers-0.2.7.2:0/0.2.7.2::gentoo  USE="-debug -doc -hscolour -profile {-test}" 31 KiB
[ebuild  N     ] dev-haskell/semigroups-0.18.2:0/0.18.2::gentoo  USE="binary transformers -doc -hscolour -profile" 17 KiB
[ebuild  N     ] dev-haskell/quickcheck-2.9.2:2/2.9.2::gentoo  USE="template_haskell -doc -hscolour -profile {-test}" 43 KiB
[ebuild  N     ] dev-util/shellcheck-0.4.7:0/0.4.7::gentoo  USE="-doc -hscolour -profile {-test}" 124 KiB

Total: 23 packages (23 new), Size of downloads: 139,429 KiB

^^

@Frenzie
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh drat, a few weeks ago I told someone Pandoc was the only thing written in Haskell I regularly used, but so is Shellcheck. xD

Please sign in to comment.