-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird highlight boxes #11644
Comments
Presumably that's just the math saying it's that tall, unless you're saying it doesn't happen in other viewers. |
It doesn't happen in Evince for example. I've just checked if its a rendering issue but it also saves the highlight that way. But as I said, in Evince I dont have this problem. (Edit) |
Based on some random PDF (https://arxiv.org/pdf/2305.17493.pdf) I'd say it's a bit of a toss up what happens to come out better where. It does generally seem to come out a bit nicer in Firefox, probably mostly as a happy coincidence due to how they lay out text. (It's regular HTML with fancy positioning, which is fundamentally quite different from how native PDF implementations work.) The (hopefully) good news is that there are likely to be some improvements here in the future regardless, due to various updated dependencies. Okular![]() ![]() Evince, KOReader on top![]() |
You can probably get a preview of that in a newer MuPDF app (whether on desktop or Android), unless it doesn't expose text selection. |
Okay, I'm doing a last recap with all the info I realize could be useful, if you tell me I just have to wait, I'll wait :) Evince selection before any modification in KOReaderEvince opening the file modified by KOReaderKOReader selection before any modificationDoing this, when I want to use reflow and then select in desktop it crashes, but I don't have time to see the logs, I'll see what's going on later. The page of the pdfI leave here the page of the pdf test.pdf. |
Curious, the geometry doesn't seem out of the ordinary in the PDF but as shown the selection returned is rather tall. (Some relevant output from
But yeah, at the moment there's a good chance it'll be fixed automatically once MuPDF is finally updated. |
Nope, I get the same tall selection boxes with a build using MuPDF 1.24.1. |
So is a problem of MuPDF? Not of KOReader? |
As a random thought, I think the Latin Modern Math font, used here for math, had a tall lineheight issue about a decade ago. Although that wouldn't explain why only MuPDF has this issue. |
So, maybe I should create an issue in MuPDF? |
I suspect this issue already covers it: https://bugs.ghostscript.com/show_bug.cgi?id=700466 Note how the screenshot of http://beta.hebrewbooks.org/pagefeed/hebrewbooks_org_9717_1.pdf shows a very tall selection in the header, when the box actually hugs the Hebrew characters. ![]() |
That's five years old, do you think this will be addressed? |
Your test case could be useful because it shows a clear contrast between desired and undesired behavior. I think it'd be worth adding there, unless @benoit-pierre has different thoughts. |
I would report the issue upstream, yes. |
Thank you guys, you've been very helpful! Do I leave the issue open? |
Let's leave it open for now. |
#11716 |
Issue
Weird highlight boxes created. This happens throughout the document, but more frequently when is near a math expression.
Steps to reproduce
I just don't know if it's legal uploading the pdf jajajaja.
The text was updated successfully, but these errors were encountered: