Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Page Browser and Book Map on NT Kindle #11908

Open
Commodore64user opened this issue May 27, 2024 · 4 comments
Open

FR: Page Browser and Book Map on NT Kindle #11908

Commodore64user opened this issue May 27, 2024 · 4 comments
Labels
enhancement help-wanted We'd like help with this issue Kindle NT Non Touch devices

Comments

@Commodore64user
Copy link
Contributor

Commodore64user commented May 27, 2024

So, I am trying to bring Page Browser and Book Map to non-touch Kindles now that we have sufficient support buttons to run it, included are screenshots from the widgets running on K4.

I was able to map the menu (hamburger on both page browser and book map) to the "Menu" key and it works great out of the box.

The book map works mostly okay with the exemption of taps, as we can obviously not tap the screen but still, the map shows you all relevant information. The page browser on the other hand seems to suffer if not the same, a similar disease as the grid view did prior to #11906. In other words the dPad does not move you around the pages nor are we able to "Press" (select) any of them.

Any help and guidance here greatly appreciated, btw roughly speaking, when do we expect the next stable release to come out?

@Frenzie
Copy link
Member

Frenzie commented May 27, 2024

Sometime in June.

@Commodore64user
Copy link
Contributor Author

Commodore64user commented May 27, 2024

(Well, I have no idea - and don't really want to know :) - how this works on a non-touch device, if that's the only device you own, according to your other issue #11295 :/)

(As seen here #11393 (comment))
Well, first we introduce book map (done #11916) then we fix page browser so that it works with key inputs. At this point we should be able to re-introduce hidden flows (removed here #11690) and we are golden.

We should be able to travel through the grid (points marked with yellow), and should be able to both Press and long-press ("Press" and "ScreenKB + Press")

Book map also needs an upgrade to support a selection tool (like blue box seen in picture) so we can move to and from page browser. (directional keys are free to be used to this purpose)

@Frenzie Frenzie added help-wanted We'd like help with this issue NT Non Touch devices Kindle labels Jun 3, 2024
Frenzie pushed a commit that referenced this issue Jun 5, 2024
as first discussed here #11908. This PR brings the book map to non-touch devices that useDPadAsActionKeys().

Book map can be accessed from the menu or by using the following shortcut: ScreenKB + Down or Shift + Down depending on whether you use a K4 device or a kindle with keyboard respectively.

Inside the book map, a user can toggle the hamburger menu by pressing the Menu key and make any adjustment from there. ScreenKB (or Shift) + Up/Down allows it to scroll and Page turn buttons to move by whole full page turns. Back key allows user to exit the map.
@Commodore64user
Copy link
Contributor Author

Commodore64user commented Jun 23, 2024

@comphilip if you have some spare time, have a look at this. no preaasure though.

@comphilip
Copy link
Contributor

@Commodore64user Add it to my todo list. Planning family vocation this month. Hoping having time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help-wanted We'd like help with this issue Kindle NT Non Touch devices
Projects
None yet
Development

No branches or pull requests

3 participants