Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocabulary Builder doesn't open with gesture #11913

Closed
ichnilatis-gr opened this issue May 27, 2024 · 2 comments · Fixed by #11915
Closed

Vocabulary Builder doesn't open with gesture #11913

ichnilatis-gr opened this issue May 27, 2024 · 2 comments · Fixed by #11915
Labels
Milestone

Comments

@ichnilatis-gr
Copy link
Contributor

  • KOReader version: v2024.04-99
  • Device: Pocketbook Touch Lux 5 (PB 628)

Issue

When I make the gesture I have assigned to open the Vocabulary Builder, it doesn't respond.

@Frenzie Frenzie added the Plugin label May 27, 2024
@hius07
Copy link
Member

hius07 commented May 27, 2024

True.

function VocabBuilder:onDispatcherRegisterActions()
Dispatcher:registerAction("show_vocab_builder",
{category="none", event="ShowVocabBuilder", title=_("Open vocabulary builder"), general=true, separator=true})
end

The event handler onShowVocabBuilder() was removed in #11777.

@Frenzie
Copy link
Member

Frenzie commented May 27, 2024

That's probably inadvertently. But yes, over the past few years we've moved several things to events precisely so they could be activated from profiles and gestures.

@nairyosangha do you have time to restore it since it's probably still fresh in your mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants