Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Bar progress bar can no longer be hidden #2303

Closed
pickx opened this issue Oct 24, 2016 · 8 comments · Fixed by #2317
Closed

Status Bar progress bar can no longer be hidden #2303

pickx opened this issue Oct 24, 2016 · 8 comments · Fixed by #2317

Comments

@pickx
Copy link

pickx commented Oct 24, 2016

  • KOReader version: v2015.11-654-gb7392f7
  • Device: Kobo Aura One

Issue

Under [Cog Icon]->Status bar it is possible to change what appears in the status bar.

However, the Progress bar is enabled by default and toggling it has no effect, it is always shown. This is a regression, as I remember being able to hide it a few months ago.

@Frenzie Frenzie added the bug label Oct 24, 2016
@AlanSP1
Copy link

AlanSP1 commented Oct 24, 2016

Maybe related with chapter marks? #2262

Just thinking aloud...

@houqp
Copy link
Member

houqp commented Oct 25, 2016

@pickx I can't reproduce this on my Aura HD and emulator. I am able to hide the bottom progress bar by tapping on it.

@AlanSP1 do you also have this issue?

@AlanSP1
Copy link

AlanSP1 commented Oct 25, 2016

Yes, I have.

I'm on 622 from your build (you shared on suspend issue topic) if it is a problem. I'm using all options visible at the same time if that is important.

If I tap on status bar and check mark isn't visible, status bar still stays on. But, other things (tested just with battery) react immediately, i.e. appear or disappear per selected status.

It may be solved on latest build if you don't see it.

Just to add, I have H2O and use KSM8 in case that helps.

@Frenzie
Copy link
Member

Frenzie commented Oct 25, 2016

Could just be a menu issue? Can't test atm.

On Oct 25, 2016 7:35 AM, "Qingping Hou" notifications@github.com wrote:

@pickx https://github.com/pickx I can't reproduce this on my Aura HD
and emulator. I am able to hide the bottom progress bar by tapping on it.

@AlanSP1 https://github.com/AlanSP1 do you also have this issue?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2303 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMYBXeaqHNrSE2vtWex8WXFCLuX9P9Zks5q3ZUHgaJpZM4Keyi8
.

@oldhasbeen
Copy link

with my Aura H2O I need to first untick the progress bar option and then exit and restart koreader. The progress bar is then gone.

@houqp
Copy link
Member

houqp commented Oct 28, 2016

Now that I reread the reader footer code, it's so bad that I think I am going to rewrite it from scratch >_< This module just went out of control after people kept adding features to it.

@houqp houqp added this to the next stable release milestone Oct 28, 2016
@KenMaltby
Copy link

Since the "Status Bar" menu has grown to two pages perhaps a "Setting may require a restart of KOReader, to show effect" warning could be added to the first page.

@houqp
Copy link
Member

houqp commented Oct 29, 2016

I am going to make it reload on the fly so no restart is needed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants