Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscroll #3019

Closed
rjbergerud opened this issue Jul 21, 2017 · 11 comments · Fixed by #5295
Closed

Autoscroll #3019

rjbergerud opened this issue Jul 21, 2017 · 11 comments · Fixed by #5295
Labels
enhancement help-wanted We'd like help with this issue Plugin

Comments

@rjbergerud
Copy link

  • KOReader version: v2015.11-1023-g773e24f
  • Device: Kobo Aura One

Issue

It would be great to have an autoscroll feature, especially for those using their device to read music. At minimum, this would include being able to control autoscroll speed. I couldn't find any similar feature requests in the issues.

Steps to reproduce

@pibone
Copy link

pibone commented Oct 4, 2017

This could be really interesting, there is an alternative, maybe better for e-ink devices.
Instead (or also 😄) of scrolling, might be useful to implement half page turns.

I guess this feature could be implemented easily.

@Frenzie
Copy link
Member

Frenzie commented Oct 4, 2017

Yes, someone could probably write a plugin relatively easily.

For the GUI you could take a cue from https://github.com/koreader/koreader/blob/db6c35c14476c4f28fdc838ae5f97bccec47ccba/frontend/apps/reader/modules/readersearch.lua

(e.g., slowest, slower/faster in small increments, fastest)

screenshot_2017-10-04_11-11-02

For distance look at

function ReaderPaging:onPagingRel(diff)
if self.view.page_scroll then
self:onScrollPageRel(diff)
else
self:onGotoPageRel(diff)
end
self:setPagePosition(self:getTopPage(), self:getTopPosition())
return true
end
function ReaderPaging:onPanningRel(diff)
if self.view.page_scroll then
self:onScrollPanRel(diff)
end
self:setPagePosition(self:getTopPage(), self:getTopPosition())
return true
end

Let me know if you need any more help. :-)

@KenMaltby
Copy link

What formats are used for "emusic" files?

@Frenzie
Copy link
Member

Frenzie commented Oct 4, 2017

Either PDF if it's properly digital or some image format (most likely encapsulated in PDF) if it's scanned afaik.

@Evidlo
Copy link

Evidlo commented Jan 25, 2018

I think half page turns would be very useful.

Often when I'm reading a math text, I'll look up a few lines to reference something. With half-page scrolling you can ensure that both pieces of information are on the same screen.

@Frenzie
Copy link
Member

Frenzie commented Jan 25, 2018

@Evidlo You mean half pageturns in autoscroll?

If you mean generically then I'd recommend turning on scroll mode. It's in the menu at the bottom.

screenshot_2018-01-25_15-54-01

That way you can just scroll up or down a little to put something into view with more precision than half page turns would give you.

@Evidlo
Copy link

Evidlo commented Jan 25, 2018

That works, but I find clicking and dragging on eink displays really unpleasant.

I think the ideal solution would be to have an option in the menu to control how much a pageturn operation moves the page. 1 page, 1/2 page, 1/4 page etc.

code in question

@Frenzie
Copy link
Member

Frenzie commented Jan 25, 2018

Does scroll mode automatically horizontally lock the page so that I don't accidentally pan left or right as I drag my finger up?

There are even complaints about it. ;-)

Scrolling works well in KOReader imo: https://vimeo.com/221283896

I think the ideal solution would be to have an option in the menu to control how much a pageturn operation moves the page. 1 page, 1/2 page, 1/4 page etc.

That already exists, although I don't think it's accessible through the menu. See #2818 (comment)

@Frenzie Frenzie added help-wanted We'd like help with this issue Plugin labels Apr 30, 2019
@kobom
Copy link

kobom commented Aug 31, 2019

I think it's not duplicate of #4984.

I have serious accessibility problems with turning pages. Is it too hard to develop a next page command that runs at certain times? I don't understand software development. Please help us with accessibility.

So sorry but please help. I'm waiting this feature for months :(

@Frenzie
Copy link
Member

Frenzie commented Sep 1, 2019

@kobom Could you please explain what you mean by it not being a duplicate? If it's about the word scrolling, the only type of "scrolling" that makes sense on E Ink is whole or partial page turns.

Is it too hard to develop a next page command that runs at certain times?

Not too hard, but not easy either. I'll see if I can write a proof of concept today. It's always easier to iterate on something already there.

Frenzie added a commit to Frenzie/koreader that referenced this issue Sep 1, 2019
Frenzie added a commit that referenced this issue Sep 1, 2019
@Frenzie
Copy link
Member

Frenzie commented Sep 1, 2019

So it's not necessarily the smoothest scroll, but you can get steady scrolling if you use values like 0.5 for time and 0.05 for distance.

mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help-wanted We'd like help with this issue Plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants