-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unicode file names not displaying correctly in history menu (kobo Aura HD issue) #354
Comments
the problem seems to be in the FileManagerHistory and in the function readHistDir(). it uses "ls" to lists the history dir while the "ls" command could not recognize unicode file name (if system locale does not support that unicode chars) Fortunately the lfs.dir() does not rely on system locale(that's what the FileChooser uses to list directory files and it works well). so the fix is to change the readHistDir to below: for f in lfs.dir("./history") do
local filemode = lfs.attributes(f, "mode")
if filemode ~= "directory" then -- we can't use filemode == "file" here, when it should be "file" it is actually nil, weird
table.insert(re, {
dir = DocSettings:getPathFromHistory(f),
name = DocSettings:getNameFromHistory(f),
})
end
end |
good catch :) Do you mind sending us a pull request? |
build: remove cmake stamp files to force update target files
see attached image, all unicode chars are displayed as "?",
my device: kobo Aura HD, language: english
if you guys need more information please let me know. thanks!
The text was updated successfully, but these errors were encountered: