Calibre Wireless connection not working since v2018.02.12-nightly

[max-cw]

• KOReader version: v2018.02.12-nightly
• Device: Kobo Auro H2Ov1

Calibre wireless connection no longer works in v2018.02.12-nightly and v2018.03.14-beta. It is working in v2018.01.10-nightly after the #3558. Seems to be a different issue.

Steps to reproduce

Connect to calibre server from the menu. It will immediately show the "cannot connect" error. I should also point out that there is no message box asking if I want to turn on the wifi if it's off, unlike v2018.01.10-nightly where the connector still works.

[max-cw]

Hi. It may be a naive thinking on my part, but I change the one line according to #3795. Now koreader asks me if I want to turn on the wifi, but the calibre wireless connection plugin still cannot connect after the wifi is connected.

[Frenzie]

Slightly breaking the wifi dialog was the only change that's been made there: https://github.com/koreader/koreader/commits/master/plugins/calibrecompanion.koplugin/main.lua

I don't really see anything else that could affect it… v2018.01.10-nightly...v2018.02.12-nightly

Except for koreader/koreader-base#593

Apparently with udp:setoption("broadcast", true) we get this error:

nil	setsockopt failed

Presumably that leads to permission denied.

We're using socket in many more places though.

@poire-z Do you have any clue?

[poire-z]

Not really (I don't use calibre, never looked at its code, and I have the wifi code quite patched on my side).
May be other calibre users could report if they notice any such problem, just to be sure it's not something local to the OP.

[max-cw]

Hi again. Just a quick comment: I have two H2Ov1, and the other one with a different setup have the same issue, so I don't think any particular setting. I could be wrong of course.

[poire-z]

And if you reinstall a koreader version from 201801, they both work (or it's just that they worked at the time you had 201801?)

[max-cw]

That is correct. 201801 works for both.

Edit: To clarify yes it works after I reinstall. I did that just now.

[Frenzie]

@poire-z I don't really know how calibre works either. It's luasocket giving these getsockopt failed and permission denied failures before it even does anything. I guess I'll look over lunarmodules/luasocket@321c0c9...6529598 later to see if anything changed. (Annoyingly, I thought updating it was just a simple bugfix… argh, side effects. :-P)

[Frenzie]

Oh, got it. A few commits after our original one they added udp4() and udp6() options.

lunarmodules/luasocket@96965b1

Changing it to udp4() works.

[poire-z]

@max-cw : you could try taking the common directory from a 201801 release, and drop it over the one from a 201803, just to confirm it's really related to luasocket.

[max-cw]

Confirm working after changing to udp4(). Cheers!