Can't set Page Overlap Enabled/Disabled as default

[pickx]

As of right now, tapping-and-holding on "Enable" or "Disable" under Page Overlap does not allow setting as default. This is inconsistent with other UI behaviour (and annoying to me because I use that feature often).

Thanks.

[Frenzie]

Looks like that whole submenu has a TODO for a rewrite:

koreader/frontend/apps/reader/modules/readerpaging.lua

Lines 184 to 203 in 229c492

	function ReaderPaging:addToMainMenu(menu_items)
	-- FIXME: repeated code with page overlap menu for readerrolling
	-- needs to keep only one copy of the logic as for the DRY principle.
	-- The difference between the two menus is only the enabled func.
	local page_overlap_menu = {
	{
	text_func = function()
	return self.show_overlap_enable and _("Disable") or _("Enable")
	end,
	callback = function()
	self.show_overlap_enable = not self.show_overlap_enable
	if not self.show_overlap_enable then
	self.view:resetDimArea()
	end
	end
	},
	}
	for _, menu_entry in ipairs(self.view:genOverlapStyleMenu()) do
	table.insert(page_overlap_menu, menu_entry)
	end

[ersi-dnd]

While this setting is awaiting an overhaul, I casually drop some suggestions.

The setting only works with Scroll Mode off. IMHO, it should also work with Scroll Mode on. By default, Koreader scrolls (in Scroll Mode) a full screen length, so that the Page Overlap indicator would be irrelevant, but in my Koreaders I always set DOVERLAPPIXELS so that Scroll Mode scrolls about half screen length, so the Page Overlap indicator is highly relevant for me with Scroll Mode on.

The Page Overlap indicator is a tiny triangle on the left side of the screen. It is often enough impossible to distinguish it from other blemishes on my quirky pdf files. As a minimum, I would like to have another tiny triangle on the right side of the screen so as to hopefully confirm that what I see on the left side is not merely a blemish on the pdf.

And I agree with the OP that the setting should be possible to make into a default, so that it's there in every next file that I open when I need it. Thanks for bringing it up.

[KenMaltby]

I thought there were more options, at one time, but there are "Page overlap >" options to: Disable, Arrow, or Gray out. The disable/enable is not a checkbox like the others, but it changes to offer the alternative option. These kind of selections are usually persistent (like a default)

[ersi-dnd]

@KenMaltby
I have not noticed that Page overlap would be enabled in new books that I open. I have to enable it, then it stays on for that particular book.

When in Scroll Mode, Page overlap menu item is grayed out. And the tiny triangle is not there, so evidently Page overlap is off in Scroll Mode and cannot be enabled at all, because the menu item is grayed out.

"Gray out" option for Page overlap is visually stunning, but not much of a use when you are trying to read the grayed out half. The tiny triangle is a better option when the user's plan is to read both halves of the screen.

[ersi-dnd]

There's also a DSHOWOVERLAP setting in the Advanced configuration thingie. As far as I can see, changing it has no effect.

[KenMaltby]

I don't see why there would be any page overlap, with scroll mode. I almost never use the scroll mode though, so it is not something my opinion should impact on much. It would be hard for the developers to establish this kind of issue's impact on users. For my usage having it a "per book" setting is fine. In your case, where you have a number of similar documents and have custom settings in place, having it applied to all documents as a default, might make sense. I am always for more user options.

[ersi-dnd]

I think page overlap is rigidly off in scroll mode because in scroll mode it scrolls a full-page length by default. It either didn't occur to anybody that someone might scroll a half-page length or the feature is not completed yet.

When scrolling a half-page length, I don't see why the page overlap indicator should not be there. Half-page scrolling is there in some of my most favourite apps, such as Elinks, w3m, less, and Ebookdroid.

[hius07]

The issue can be closed (with #8180).